netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: dann frazier <dann.frazier@canonical.com>
To: "lipeng (Y)" <lipeng321@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>,
	davem@davemloft.net, yisen.zhuang@huawei.com,
	mehta.salil@opnsrc.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH net-next] net: hns3: Config NIC port speed same as that of optical module
Date: Thu, 3 Jan 2019 10:41:32 -0700	[thread overview]
Message-ID: <20190103174132.GA19859@xps13.dannf> (raw)
In-Reply-To: <aadad75b-a3fe-8bf1-77ce-14d3375ce4fd@huawei.com>

On Wed, Jan 02, 2019 at 08:45:36PM +0800, lipeng (Y) wrote:
> 
> 
> On 2019/1/1 9:22, dann frazier wrote:
> > On Mon, Nov 26, 2018 at 06:43:00PM +0000, Salil Mehta wrote:
> > > From: Peng Li <lipeng321@huawei.com>
> > > 
> > > Port 0/1 of HiP08 supports 10G and 25G. This patch adds a
> > > change to configure NIC port speed same as that of  optical
> > > module(SFP/QFSP). Driver gets the optical module speed and
> > > sets NIC port speed accordingly.
> > Hi,
> > 
> > I'm getting the following errors in dmesg about every 1s on a D06:
> > 
> > [  766.761823] hns3 0000:bd:00.0: get sfp speed failed -5
> > [  767.785823] hns3 0000:bd:00.0: get sfp speed failed -5
> > [  768.809820] hns3 0000:bd:00.0: get sfp speed failed -5
> > [  769.833818] hns3 0000:bd:00.0: get sfp speed failed -5
> > 
> > Reverting this patch fixes the issue.
> > 
> >   -dann
> Hi,dann,
> 
> Thanks for your test and report.
> 
> This patch needs to match new fireware verison ,
> And  it  does some work to  be Compatible with older versions.

I did upgrade to the latest available firmware (20181213-b20), but the
problem persisted. Maybe the necessary firmware is not yet released?

> Can you show me more information?
> can you  use "ethtool -i ethx" to get the fireware version ,
> and shows me  some other message about hns3?

Sure: 

$ sudo ethtool -i enp125s0f2
driver: hns3
version: 4.20.0+ SMP mod_unload aarch64
firmware-version: 0xb0311019
expansion-rom-version: 
bus-info: 0000:7d:00.2
supports-statistics: yes
supports-test: yes
supports-eeprom-access: no
supports-register-dump: yes
supports-priv-flags: no

  -dann

      reply	other threads:[~2019-01-03 17:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 18:43 [PATCH net-next] net: hns3: Config NIC port speed same as that of optical module Salil Mehta
2018-11-28  0:33 ` David Miller
2019-01-01  1:22 ` dann frazier
2019-01-02 12:45   ` lipeng (Y)
2019-01-03 17:41     ` dann frazier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103174132.GA19859@xps13.dannf \
    --to=dann.frazier@canonical.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=lipeng321@huawei.com \
    --cc=mehta.salil@opnsrc.net \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).