From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: [PATCH ipsec 2/7] xfrm: policy: use hlist rcu variants on inexact insert, part 2 Date: Fri, 4 Jan 2019 14:17:00 +0100 Message-ID: <20190104131705.9550-3-fw@strlen.de> References: <20190104131705.9550-1-fw@strlen.de> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: xiyou.wangcong@gmail.com, , Florian Westphal To: steffen.klassert@secunet.com Return-path: Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:52490 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727959AbfADNTX (ORCPT ); Fri, 4 Jan 2019 08:19:23 -0500 In-Reply-To: <20190104131705.9550-1-fw@strlen.de> Sender: netdev-owner@vger.kernel.org List-ID: This function was modeled on the 'exact' insert one, which did not use the rcu variant either. When I fixed the 'exact' insert I forgot to propagate this to my development tree, so the inexact variant retained the bug. Fixes: 9cf545ebd591d ("xfrm: policy: store inexact policies in a tree ordered by destination address") Signed-off-by: Florian Westphal --- net/xfrm/xfrm_policy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index 934492bad8e0..628b389af2ba 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm/xfrm_policy.c @@ -856,9 +856,9 @@ static void xfrm_policy_inexact_list_reinsert(struct net *net, } if (newpos) - hlist_add_behind(&policy->bydst, newpos); + hlist_add_behind_rcu(&policy->bydst, newpos); else - hlist_add_head(&policy->bydst, &n->hhead); + hlist_add_head_rcu(&policy->bydst, &n->hhead); /* paranoia checks follow. * Check that the reinserted policy matches at least -- 2.19.2