From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 2/2] ptp: uapi: change _IOW to IOWR in PTP_SYS_OFFSET_EXTENDED definition Date: Mon, 07 Jan 2019 08:29:58 -0800 (PST) Message-ID: <20190107.082958.2244476771234919771.davem@davemloft.net> References: <20181109101449.15398-4-mlichvar@redhat.com> <20190107152238.GA18065@asgard.redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mlichvar@redhat.com, netdev@vger.kernel.org, richardcochran@gmail.com, jacob.e.keller@intel.com, mtosatti@redhat.com To: esyr@redhat.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:57840 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727099AbfAGQaA (ORCPT ); Mon, 7 Jan 2019 11:30:00 -0500 In-Reply-To: <20190107152238.GA18065@asgard.redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eugene Syromiatnikov Date: Mon, 7 Jan 2019 16:22:38 +0100 > --- a/include/uapi/linux/ptp_clock.h > +++ b/include/uapi/linux/ptp_clock.h > @@ -147,7 +147,7 @@ struct ptp_pin_desc { > #define PTP_SYS_OFFSET_PRECISE \ > _IOWR(PTP_CLK_MAGIC, 8, struct ptp_sys_offset_precise) > #define PTP_SYS_OFFSET_EXTENDED \ > - _IOW(PTP_CLK_MAGIC, 9, struct ptp_sys_offset_extended) > + _IOWR(PTP_CLK_MAGIC, 9, struct ptp_sys_offset_extended) Again, this changes the ioctl cmd value and will break userspace.