From: David Miller <davem@davemloft.net>
To: mlichvar@redhat.com
Cc: esyr@redhat.com, netdev@vger.kernel.org,
richardcochran@gmail.com, jacob.e.keller@intel.com,
mtosatti@redhat.com
Subject: Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended
Date: Mon, 07 Jan 2019 09:13:34 -0800 (PST) [thread overview]
Message-ID: <20190107.091334.2284395715402499091.davem@davemloft.net> (raw)
In-Reply-To: <20190107165741.GD27782@localhost>
From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Mon, 7 Jan 2019 17:57:41 +0100
> On Mon, Jan 07, 2019 at 08:29:38AM -0800, David Miller wrote:
>> From: Eugene Syromiatnikov <esyr@redhat.com>
>> Date: Mon, 7 Jan 2019 16:22:29 +0100
>>
>> > Otherwise it is impossible to use it for something else, as it will break
>> > userspace that puts garbage there.
>> >
>> > The same check should be done in other structures, but the fact that
>> > data in reserved fields is ignored is already part of the kernel ABI.
>> >
>> > Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
>>
>> I think the opportunity to enforce this has passed and you will break
>> userspace by doing this.
>
> FWIW, this ioctl wasn't present in a stable Linux release yet and the
> two applications that I know that support it both zero the rsv field,
> so I think at least this patch is very unlikely to break anything.
>
> Anyway, thanks to Eugene for catching the issues.
Oh, this ioctl went into this merge window didn't it.
Ok. I'll keep reviewing this then.
next prev parent reply other threads:[~2019-01-07 17:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 10:14 [PATCH net-next 0/8] More accurate PHC<->system clock synchronization Miroslav Lichvar
2018-11-09 10:14 ` [PATCH net-next 1/8] ptp: reorder declarations in ptp_ioctl() Miroslav Lichvar
2018-11-09 10:14 ` [PATCH net-next 2/8] ptp: check gettime64 return code in PTP_SYS_OFFSET ioctl Miroslav Lichvar
2018-11-09 10:14 ` [PATCH net-next 3/8] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl Miroslav Lichvar
2019-01-07 15:22 ` [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended Eugene Syromiatnikov
2019-01-07 16:29 ` David Miller
2019-01-07 16:57 ` Miroslav Lichvar
2019-01-07 17:13 ` David Miller [this message]
2019-01-08 5:19 ` Richard Cochran
2019-01-08 14:38 ` Eugene Syromiatnikov
2019-01-08 20:45 ` Keller, Jacob E
2019-01-07 15:22 ` [PATCH net 2/2] ptp: uapi: change _IOW to IOWR in PTP_SYS_OFFSET_EXTENDED definition Eugene Syromiatnikov
2019-01-07 16:29 ` David Miller
2018-11-09 10:14 ` [PATCH net-next 4/8] ptp: deprecate gettime64() in favor of gettimex64() Miroslav Lichvar
2018-11-09 10:14 ` [PATCH net-next 5/8] e1000e: extend PTP gettime function to read system clock Miroslav Lichvar
2018-11-10 1:53 ` Jeff Kirsher
2018-11-09 10:14 ` [PATCH net-next 6/8] igb: " Miroslav Lichvar
2018-11-10 1:53 ` Jeff Kirsher
2018-11-09 10:14 ` [PATCH net-next 7/8] ixgbe: " Miroslav Lichvar
2018-11-09 18:14 ` Keller, Jacob E
2018-11-10 1:52 ` Jeff Kirsher
2018-11-09 10:14 ` [PATCH net-next 8/8] tg3: " Miroslav Lichvar
2018-11-09 18:12 ` [PATCH net-next 0/8] More accurate PHC<->system clock synchronization Keller, Jacob E
2018-11-09 23:28 ` David Miller
2018-11-09 23:33 ` Jeff Kirsher
2018-11-10 0:55 ` David Miller
2018-11-10 1:44 ` Richard Cochran
2018-11-10 3:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107.091334.2284395715402499091.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=esyr@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=mlichvar@redhat.com \
--cc=mtosatti@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).