From: Florian Westphal <fw@strlen.de>
To: "Mohandass, Roobesh" <Roobesh_Mohandass@McAfee.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: : getsockopt(fd, SOL_IP, SO_ORIGINAL_DST, sa, &salen) is in fact sometimes returning the source IP instead the destination IP
Date: Mon, 7 Jan 2019 12:17:53 +0100 [thread overview]
Message-ID: <20190107111753.aiabujukqx3eteqb@breakpoint.cc> (raw)
In-Reply-To: <MWHPR16MB1502F6F7D906B1C7117189DFEDB20@MWHPR16MB1502.namprd16.prod.outlook.com>
Mohandass, Roobesh <Roobesh_Mohandass@McAfee.com> wrote:
> Issue: getsockopt(fd, SOL_IP, SO_ORIGINAL_DST, sa, &salen) is in fact sometimes returning the source IP instead the destination IP
SO_ORIGINAL_DST returns the original address (before DNAT/REDIRECT rewrite)
that conntrack believes to be the originator.
> What you expected to happen:
> getsockopt(fd, SOL_IP, SO_ORIGINAL_DST, sa, &salen) - should return always destination IP(connected IP).
>
> What happened instead:
> getsockopt(fd, SOL_IP, SO_ORIGINAL_DST, sa, &salen) is in fact sometimes returning the source IP instead the destination IP. Using getsockname() instead looks like solving the issue.
>
> For just an example:
> Out of 6569124 requests , 4 requests were wrong 0.000060891 % (this is just an rough estimate to give you idea on frequency)
>
> Some old reference: (similar behavior observed)
> https://stackoverflow.com/questions/11417187/getsockopt-so-original-dst-occasionally-returns-client-address
I ask exactly same question as in your url.
If you use TPROXY, why do you use SO_ORIGINAL_DST?
Its only required with -j REDIRECT.
If you need to use REDIRECT for some reason, make sure you limit
REDIRECT to -p tcp --syn to prevent it from triggering on other packets.
You might also want to turn off midstream pickup (sysctl
nf_conntrack_tcp_loose=0) in conntrack.
next prev parent reply other threads:[~2019-01-07 11:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <MWHPR16MB1502549F7BAAE102EF1D5DF4EDB50@MWHPR16MB1502.namprd16.prod.outlook.com>
[not found] ` <MWHPR16MB150233EF69CFD4562BFA65ABEDB60@MWHPR16MB1502.namprd16.prod.outlook.com>
[not found] ` <MWHPR16MB1502DC55542EBA8121631B16EDB20@MWHPR16MB1502.namprd16.prod.outlook.com>
2018-12-31 6:20 ` : getsockopt(fd, SOL_IP, SO_ORIGINAL_DST, sa, &salen) is in fact sometimes returning the source IP instead the destination IP Mohandass, Roobesh
2019-01-07 11:17 ` Florian Westphal [this message]
2019-01-07 14:57 ` Mohandass, Roobesh
2019-01-12 14:37 ` Lukas Tribus
2019-01-12 14:37 ` [NETDEV]: " Lukas Tribus
2019-01-12 16:04 ` : " Florian Westphal
2019-01-12 16:04 ` [NETDEV]: " Florian Westphal
2019-01-12 17:26 ` : " Willy Tarreau
2019-01-12 17:26 ` [NETDEV]: " Willy Tarreau
2019-01-12 18:01 ` : " Lukas Tribus
2019-01-12 18:01 ` [NETDEV]: " Lukas Tribus
2019-01-12 18:33 ` : " Willy Tarreau
2019-01-12 18:33 ` [NETDEV]: " Willy Tarreau
2019-01-17 5:23 ` Mohandass, Roobesh
2019-01-23 8:07 ` Mohandass, Roobesh
2019-01-23 8:54 ` Willy Tarreau
[not found] ` <MWHPR16MB1502A336CCB4EF3F0FCB69ECEDB20@MWHPR16MB1502.namprd16.prod.outlook.com>
2019-01-07 7:58 ` : " Mohandass, Roobesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107111753.aiabujukqx3eteqb@breakpoint.cc \
--to=fw@strlen.de \
--cc=Roobesh_Mohandass@McAfee.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).