From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2-next 2/3] ip link: Drop cache entry on name changes Date: Mon, 7 Jan 2019 16:06:50 -0800 Message-ID: <20190107160650.16d956d0@hermes.lan> References: <20190107225552.8441-1-dsahern@kernel.org> <20190107225552.8441-3-dsahern@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, David Ahern To: David Ahern Return-path: Received: from mail-pf1-f193.google.com ([209.85.210.193]:38250 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbfAHAGx (ORCPT ); Mon, 7 Jan 2019 19:06:53 -0500 Received: by mail-pf1-f193.google.com with SMTP id q1so970827pfi.5 for ; Mon, 07 Jan 2019 16:06:52 -0800 (PST) In-Reply-To: <20190107225552.8441-3-dsahern@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 7 Jan 2019 14:55:51 -0800 David Ahern wrote: > +int iplink_parse(int argc, char **argv, struct iplink_req *req, char **type, > + bool *name_change); Not a real fan of adding another by reference return value flag. It makes the logic flow more complex. Is there another way? Caching in general is dicey anyway.