* [PATCH] phy: ti: Fix compilation failures without REGMAP
@ 2019-01-07 17:48 Jason Gunthorpe
2019-01-07 18:13 ` Andrew Lunn
0 siblings, 1 reply; 5+ messages in thread
From: Jason Gunthorpe @ 2019-01-07 17:48 UTC (permalink / raw)
To: Grygorii Strashko, Kishon Vijay Abraham I
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
This driver requires regmap or the compile fails:
drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’
const struct reg_field (*regfields)[PHY_GMII_SEL_LAST];
Add it to kconfig.
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---
drivers/phy/ti/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
index f137e010776463..c4709ed7fb0e72 100644
--- a/drivers/phy/ti/Kconfig
+++ b/drivers/phy/ti/Kconfig
@@ -82,6 +82,7 @@ config PHY_TI_GMII_SEL
default y if TI_CPSW=y
depends on TI_CPSW || COMPILE_TEST
select GENERIC_PHY
+ select REGMAP
default m
help
This driver supports configuring of the TI CPSW Port mode depending on
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] phy: ti: Fix compilation failures without REGMAP
2019-01-07 17:48 [PATCH] phy: ti: Fix compilation failures without REGMAP Jason Gunthorpe
@ 2019-01-07 18:13 ` Andrew Lunn
2019-01-07 18:17 ` Jason Gunthorpe
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2019-01-07 18:13 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Grygorii Strashko, Kishon Vijay Abraham I,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
On Mon, Jan 07, 2019 at 05:48:00PM +0000, Jason Gunthorpe wrote:
> This driver requires regmap or the compile fails:
>
> drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’
> const struct reg_field (*regfields)[PHY_GMII_SEL_LAST];
>
> Add it to kconfig.
Hi Jason
It looks like more of the TI drivers need REGMAP, but don't select it.
I assume you are using COMPILE_TEST, since TI_CPSW selects REGMAP?
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] phy: ti: Fix compilation failures without REGMAP
2019-01-07 18:13 ` Andrew Lunn
@ 2019-01-07 18:17 ` Jason Gunthorpe
0 siblings, 0 replies; 5+ messages in thread
From: Jason Gunthorpe @ 2019-01-07 18:17 UTC (permalink / raw)
To: Andrew Lunn
Cc: Grygorii Strashko, Kishon Vijay Abraham I,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
On Mon, Jan 07, 2019 at 07:13:00PM +0100, Andrew Lunn wrote:
> On Mon, Jan 07, 2019 at 05:48:00PM +0000, Jason Gunthorpe wrote:
> > This driver requires regmap or the compile fails:
> >
> > drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’
> > const struct reg_field (*regfields)[PHY_GMII_SEL_LAST];
> >
> > Add it to kconfig.
>
> Hi Jason
>
> It looks like more of the TI drivers need REGMAP, but don't select it.
> I assume you are using COMPILE_TEST, since TI_CPSW selects REGMAP?
Yes, this causes COMPILE_TEST kernels to fail.
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] phy: ti: Fix compilation failures without REGMAP
@ 2019-01-07 17:54 Jason Gunthorpe
2019-01-07 19:23 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Jason Gunthorpe @ 2019-01-07 17:54 UTC (permalink / raw)
To: Grygorii Strashko, Kishon Vijay Abraham I
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
This driver requires regmap or the compile fails:
drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’
const struct reg_field (*regfields)[PHY_GMII_SEL_LAST];
Add it to kconfig.
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---
drivers/phy/ti/Kconfig | 1 +
1 file changed, 1 insertion(+)
.. and this is why I'm even compiling this thing when I'm not doing
anything with CPSW ..
diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
index f137e010776463..c4709ed7fb0e72 100644
--- a/drivers/phy/ti/Kconfig
+++ b/drivers/phy/ti/Kconfig
@@ -82,6 +82,7 @@ config PHY_TI_GMII_SEL
default y if TI_CPSW=y
depends on TI_CPSW || COMPILE_TEST
select GENERIC_PHY
+ select REGMAP
default m
help
This driver supports configuring of the TI CPSW Port mode depending on
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] phy: ti: Fix compilation failures without REGMAP
2019-01-07 17:54 Jason Gunthorpe
@ 2019-01-07 19:23 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2019-01-07 19:23 UTC (permalink / raw)
To: jgg; +Cc: grygorii.strashko, kishon, linux-kernel, netdev
From: Jason Gunthorpe <jgg@mellanox.com>
Date: Mon, 7 Jan 2019 17:54:14 +0000
> This driver requires regmap or the compile fails:
>
> drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’
> const struct reg_field (*regfields)[PHY_GMII_SEL_LAST];
>
> Add it to kconfig.
>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-07 19:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-07 17:48 [PATCH] phy: ti: Fix compilation failures without REGMAP Jason Gunthorpe
2019-01-07 18:13 ` Andrew Lunn
2019-01-07 18:17 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2019-01-07 17:54 Jason Gunthorpe
2019-01-07 19:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).