From: Andrew Lunn <andrew@lunn.ch>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] phy: ti: Fix compilation failures without REGMAP
Date: Mon, 7 Jan 2019 19:13:00 +0100 [thread overview]
Message-ID: <20190107181300.GB27783@lunn.ch> (raw)
In-Reply-To: <20190107174753.GA4051@ziepe.ca>
On Mon, Jan 07, 2019 at 05:48:00PM +0000, Jason Gunthorpe wrote:
> This driver requires regmap or the compile fails:
>
> drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’
> const struct reg_field (*regfields)[PHY_GMII_SEL_LAST];
>
> Add it to kconfig.
Hi Jason
It looks like more of the TI drivers need REGMAP, but don't select it.
I assume you are using COMPILE_TEST, since TI_CPSW selects REGMAP?
Andrew
next prev parent reply other threads:[~2019-01-07 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 17:48 [PATCH] phy: ti: Fix compilation failures without REGMAP Jason Gunthorpe
2019-01-07 18:13 ` Andrew Lunn [this message]
2019-01-07 18:17 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2019-01-07 17:54 Jason Gunthorpe
2019-01-07 19:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107181300.GB27783@lunn.ch \
--to=andrew@lunn.ch \
--cc=grygorii.strashko@ti.com \
--cc=jgg@mellanox.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).