From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] phy: ti: Fix compilation failures without REGMAP Date: Mon, 7 Jan 2019 19:13:00 +0100 Message-ID: <20190107181300.GB27783@lunn.ch> References: <20190107174753.GA4051@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Grygorii Strashko , Kishon Vijay Abraham I , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" To: Jason Gunthorpe Return-path: Content-Disposition: inline In-Reply-To: <20190107174753.GA4051@ziepe.ca> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Jan 07, 2019 at 05:48:00PM +0000, Jason Gunthorpe wrote: > This driver requires regmap or the compile fails: > > drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’ > const struct reg_field (*regfields)[PHY_GMII_SEL_LAST]; > > Add it to kconfig. Hi Jason It looks like more of the TI drivers need REGMAP, but don't select it. I assume you are using COMPILE_TEST, since TI_CPSW selects REGMAP? Andrew