From: Jason Gunthorpe <jgg@ziepe.ca>
To: Joe Perches <joe@perches.com>
Cc: Gal Pressman <galpress@amazon.com>,
Bart Van Assche <bvanassche@acm.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Tariq Toukan <tariqt@mellanox.com>,
xavier.huwei@huawei.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Stephen Warren <swarren@nvidia.com>,
Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] coding-style: Clarify the expectations around bool
Date: Mon, 7 Jan 2019 16:25:13 -0700 [thread overview]
Message-ID: <20190107232513.GA5336@ziepe.ca> (raw)
In-Reply-To: <8ec3603317f477fe9923b87499a33da7a2cf81ff.camel@perches.com>
On Mon, Jan 07, 2019 at 02:10:22PM -0800, Joe Perches wrote:
> On Mon, 2019-01-07 at 14:11 -0700, Jason Gunthorpe wrote:
> > There has been some confusion since checkpatch started warning about bool
> > use in structures, and people have been avoiding using it.
> >
> > Many people feel there is still a legitimate place for bool in structures,
> > so provide some guidance on bool usage derived from the entire thread that
> > spawned the checkpatch warning.
>
> Thanks Jason.
>
> It'd be nice to combine this with some better checkpatch warning or
> even a removal of that misleading warning from checkpatch
> altogether.
Okay, do you have a preference?
> With a couple minor nits below and and Ack if
> you want one:
>
> Acked-by: Joe Perches <joe@perches.com>
Thanks, I made the revisions with Bart's extra words. I'll send a v4
in a few days.
Jason
next prev parent reply other threads:[~2019-01-07 23:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 21:11 [PATCH v3] coding-style: Clarify the expectations around bool Jason Gunthorpe
2019-01-07 22:10 ` Joe Perches
2019-01-07 22:50 ` Bart Van Assche
2019-01-07 23:25 ` Jason Gunthorpe [this message]
2019-01-08 0:38 ` Joe Perches
2019-01-08 3:21 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107232513.GA5336@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=tariqt@mellanox.com \
--cc=torvalds@linux-foundation.org \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).