From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v5 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL Date: Tue, 8 Jan 2019 20:43:43 +0100 Message-ID: <20190108194343.GE1900@hirez.programming.kicks-ass.net> References: <20181220182904.4193196-1-songliubraving@fb.com> <20181220182904.4193196-2-songliubraving@fb.com> <20190108183127.GB30894@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: lkml , Netdev , Arnaldo Carvalho de Melo , Alexei Starovoitov , Daniel Borkmann , Kernel Team To: Song Liu Return-path: Received: from bombadil.infradead.org ([198.137.202.133]:49870 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731283AbfAHTnt (ORCPT ); Tue, 8 Jan 2019 14:43:49 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 08, 2019 at 06:56:19PM +0000, Song Liu wrote: > I don't think we need u64 length. 32 bit should be more than enough. > > How about we revise it as: Yep, works. Although I would not introduce types we're not yet generating. We can add those easily enough when needed.