From: Peter Zijlstra <peterz@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
acme@kernel.org, ast@kernel.org, daniel@iogearbox.net,
kernel-team@fb.com
Subject: Re: [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT
Date: Tue, 8 Jan 2019 20:59:23 +0100 [thread overview]
Message-ID: <20190108195923.GD30894@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20181220182904.4193196-4-songliubraving@fb.com>
On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote:
> +static void perf_event_bpf_emit_ksymbols(struct bpf_prog *prog,
> + enum perf_bpf_event_type type)
> +{
> + bool unregister = type == PERF_BPF_EVENT_PROG_UNLOAD;
> + int i;
> +
> + if (prog->aux->func_cnt == 0) {
> + perf_event_ksymbol(PERF_RECORD_MISC_KSYMBOL_TYPE_BPF,
> + (u64)(unsigned long)prog->bpf_func,
> + prog->jited_len, unregister,
> + perf_event_bpf_get_name, prog);
> + } else {
> + for (i = 0; i < prog->aux->func_cnt; i++) {
> + struct bpf_prog *subprog = prog->aux->func[i];
> +
> + perf_event_ksymbol(
> + PERF_RECORD_MISC_KSYMBOL_TYPE_BPF,
> + (u64)(unsigned long)subprog->bpf_func,
> + subprog->jited_len, unregister,
> + perf_event_bpf_get_name, subprog);
> + }
> + }
> +}
That's a bit unexpected, but yes sure, that works for now.
I was expecting it to be hooked up in your kallsym rbtree thing, but
whatever, we can fix that when needed.
next prev parent reply other threads:[~2019-01-08 19:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 18:28 [PATCH v5 perf, bpf-next 0/7] reveal invisible bpf programs Song Liu
2018-12-20 18:28 ` [PATCH v5 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL Song Liu
2019-01-08 18:31 ` Peter Zijlstra
2019-01-08 18:56 ` Song Liu
2019-01-08 19:43 ` Peter Zijlstra
2018-12-20 18:28 ` [PATCH v5 perf, bpf-next 2/7] sync tools/include/uapi/linux/perf_event.h Song Liu
2018-12-20 18:29 ` [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT Song Liu
2019-01-08 18:41 ` Peter Zijlstra
2019-01-08 19:10 ` Song Liu
2019-01-08 19:43 ` Peter Zijlstra
2019-01-08 23:54 ` Song Liu
2019-01-08 23:54 ` Song Liu
2019-01-09 10:18 ` Peter Zijlstra
2019-01-09 10:18 ` Peter Zijlstra
2019-01-09 11:32 ` Song Liu
2019-01-09 11:32 ` Song Liu
2019-01-09 12:59 ` Peter Zijlstra
2019-01-09 12:59 ` Peter Zijlstra
2019-01-09 16:04 ` Song Liu
2019-01-09 16:04 ` Song Liu
2019-01-08 20:16 ` Arnaldo Carvalho de Melo
2019-01-08 23:37 ` Song Liu
2019-01-08 23:37 ` Song Liu
2019-01-08 20:56 ` Alexei Starovoitov
2019-01-08 20:56 ` Alexei Starovoitov
2019-01-08 19:59 ` Peter Zijlstra [this message]
2019-01-08 20:29 ` Peter Zijlstra
2019-01-08 20:45 ` Alexei Starovoitov
2019-01-08 20:45 ` Alexei Starovoitov
2019-01-09 12:41 ` Peter Zijlstra
2019-01-09 12:41 ` Peter Zijlstra
2019-01-09 15:51 ` Song Liu
2019-01-09 15:51 ` Song Liu
2018-12-20 18:29 ` [PATCH v5 perf, bpf-next 4/7] sync tools/include/uapi/linux/perf_event.h Song Liu
2018-12-20 18:29 ` [PATCH v5 perf, bpf-next 5/7] perf util: handle PERF_RECORD_KSYMBOL Song Liu
2018-12-20 18:29 ` [PATCH v5 perf, bpf-next 6/7] perf util: handle PERF_RECORD_BPF_EVENT Song Liu
2018-12-20 18:29 ` [PATCH v5 perf, bpf-next 7/7] perf tools: synthesize PERF_RECORD_* for loaded BPF programs Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108195923.GD30894@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).