From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v2 4/5] net: phy: at803x: Disable phy delay for RGMII mode Date: Wed, 9 Jan 2019 10:05:50 +0530 Message-ID: <20190109043550.GU13372@vkoul-mobl.Dlink> References: <20190108162926.17806-1-vkoul@kernel.org> <20190108162926.17806-5-vkoul@kernel.org> <3baa95a5-5905-5d34-b656-698c792e6716@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David S Miller , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Niklas Cassel , Bjorn Andersson , Andrew Lunn To: Florian Fainelli Return-path: Received: from mail.kernel.org ([198.145.29.99]:42082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727947AbfAIEh1 (ORCPT ); Tue, 8 Jan 2019 23:37:27 -0500 Content-Disposition: inline In-Reply-To: <3baa95a5-5905-5d34-b656-698c792e6716@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi Florian, Thanks for a quick review, On 08-01-19, 09:59, Florian Fainelli wrote: > On 1/8/19 8:29 AM, Vinod Koul wrote: > > + if (phydev->interface == PHY_INTERFACE_MODE_RGMII) { > > + ret = at803x_disable_rx_delay(phydev); > > + if (ret < 0) > > + return ret; > > + ret = at803x_disable_tx_delay(phydev); > > + if (ret < 0) > > + return ret; > > + } > > This looks right in that PHY_INTERFACE_MODE_RGMII from the perspective > of the PHY means no TX/RX delays, but you would also have to take care > of PHY_INTERFACE_MODE_RGMII_TXID and disable the RX delay in that case, > and PHY_INTERFACE_MODE_RGMII_RXID and disabled the TX delay in that case. Okay and I guess same about the PHY_INTERFACE_MODE_RGMII_ID. Right now driver enables delay for PHY_INTERFACE_MODE_RGMII_ID and PHY_INTERFACE_MODE_RGMII_TXID, PHY_INTERFACE_MODE_RGMII_RXID so I would remove that as well.. Thanks -- ~Vinod