From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR Date: Wed, 9 Jan 2019 09:50:11 -0500 Message-ID: <20190109094959-mutt-send-email-mst@kernel.org> References: <20190102205715.14054-1-mst@redhat.com> <20190102205715.14054-2-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nick Desaulniers , LKML , Jason Wang , Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , linux-arch@vger.kernel.org, Network Development , virtualization@lists.linux-foundation.org, Eli Friedman , Joe Perches < To: Miguel Ojeda Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59508 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732083AbfAIOuS (ORCPT ); Wed, 9 Jan 2019 09:50:18 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers wrote: > > > > Also for more context, see: > > commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against > > dead store elimination") > > By the way, shouldn't that barrier_data() be directly in compiler.h > too, since it is for both gcc & clang? > > > Reviewed-by: Nick Desaulniers > > > > + Miguel > > Miguel, would you mind taking this into your compiler-attributes tree? > > Sure, at least we get quickly some linux-next time. > > Note it would be nice to separate the patch into two (one for the > comments, another for OPTIMIZER_HIDE_VAR), and also possibly another > for barrier_data(). > > Cheers, > Miguel Okay, I will try. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087ECC43387 for ; Wed, 9 Jan 2019 14:50:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D85432070B for ; Wed, 9 Jan 2019 14:50:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732116AbfAIOuX (ORCPT ); Wed, 9 Jan 2019 09:50:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59508 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732083AbfAIOuS (ORCPT ); Wed, 9 Jan 2019 09:50:18 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 827E3CD263; Wed, 9 Jan 2019 14:50:17 +0000 (UTC) Received: from redhat.com (ovpn-123-72.rdu2.redhat.com [10.10.123.72]) by smtp.corp.redhat.com (Postfix) with SMTP id 63AF23DA7; Wed, 9 Jan 2019 14:50:12 +0000 (UTC) Date: Wed, 9 Jan 2019 09:50:11 -0500 From: "Michael S. Tsirkin" To: Miguel Ojeda Cc: Nick Desaulniers , LKML , Jason Wang , Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , linux-arch@vger.kernel.org, Network Development , virtualization@lists.linux-foundation.org, Eli Friedman , Joe Perches , Linus Torvalds , Luc Van Oostenryck , linux-sparse@vger.kernel.org, Eric Christopher Subject: Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR Message-ID: <20190109094959-mutt-send-email-mst@kernel.org> References: <20190102205715.14054-1-mst@redhat.com> <20190102205715.14054-2-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 09 Jan 2019 14:50:18 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Message-ID: <20190109145011.uEnlFdL_9br4D3_SYB_eVf3v3J9TDMszG5iHOL6cWCE@z> On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers wrote: > > > > Also for more context, see: > > commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against > > dead store elimination") > > By the way, shouldn't that barrier_data() be directly in compiler.h > too, since it is for both gcc & clang? > > > Reviewed-by: Nick Desaulniers > > > > + Miguel > > Miguel, would you mind taking this into your compiler-attributes tree? > > Sure, at least we get quickly some linux-next time. > > Note it would be nice to separate the patch into two (one for the > comments, another for OPTIMIZER_HIDE_VAR), and also possibly another > for barrier_data(). > > Cheers, > Miguel Okay, I will try. -- MST