* [PATCH net] selftests/txtimestamp: Fix an equals vs assign bug
@ 2019-01-09 10:50 Dan Carpenter
2019-01-09 13:24 ` Willem de Bruijn
2019-01-15 21:45 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2019-01-09 10:50 UTC (permalink / raw)
To: Willem de Bruijn
Cc: Shuah Khan, David S. Miller, Soheil Hassas Yeganeh,
Vinicius Costa Gomes, linux-kselftest, netdev, kernel-janitors
This should be == instead of =.
Fixes: b52354aa068e ("selftests: expand txtimestamp with ipv6 dgram + raw and pf_packet")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
tools/testing/selftests/networking/timestamping/txtimestamp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/networking/timestamping/txtimestamp.c b/tools/testing/selftests/networking/timestamping/txtimestamp.c
index 2e563d17cf0c..d1bbafb16f47 100644
--- a/tools/testing/selftests/networking/timestamping/txtimestamp.c
+++ b/tools/testing/selftests/networking/timestamping/txtimestamp.c
@@ -240,7 +240,7 @@ static void __recv_errmsg_cmsg(struct msghdr *msg, int payload_len)
cm->cmsg_type == IP_RECVERR) ||
(cm->cmsg_level == SOL_IPV6 &&
cm->cmsg_type == IPV6_RECVERR) ||
- (cm->cmsg_level = SOL_PACKET &&
+ (cm->cmsg_level == SOL_PACKET &&
cm->cmsg_type == PACKET_TX_TIMESTAMP)) {
serr = (void *) CMSG_DATA(cm);
if (serr->ee_errno != ENOMSG ||
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] selftests/txtimestamp: Fix an equals vs assign bug
2019-01-09 10:50 [PATCH net] selftests/txtimestamp: Fix an equals vs assign bug Dan Carpenter
@ 2019-01-09 13:24 ` Willem de Bruijn
2019-01-15 21:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2019-01-09 13:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: Willem de Bruijn, Shuah Khan, David S. Miller,
Soheil Hassas Yeganeh, Vinicius Costa Gomes, linux-kselftest,
Network Development, kernel-janitors
On Wed, Jan 9, 2019 at 5:52 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> This should be == instead of =.
>
> Fixes: b52354aa068e ("selftests: expand txtimestamp with ipv6 dgram + raw and pf_packet")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Thanks for the fix, Dan.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] selftests/txtimestamp: Fix an equals vs assign bug
2019-01-09 10:50 [PATCH net] selftests/txtimestamp: Fix an equals vs assign bug Dan Carpenter
2019-01-09 13:24 ` Willem de Bruijn
@ 2019-01-15 21:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-01-15 21:45 UTC (permalink / raw)
To: dan.carpenter
Cc: willemb, shuah, soheil, vinicius.gomes, linux-kselftest, netdev,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 9 Jan 2019 13:50:07 +0300
> This should be == instead of =.
>
> Fixes: b52354aa068e ("selftests: expand txtimestamp with ipv6 dgram + raw and pf_packet")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-15 21:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-09 10:50 [PATCH net] selftests/txtimestamp: Fix an equals vs assign bug Dan Carpenter
2019-01-09 13:24 ` Willem de Bruijn
2019-01-15 21:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).