From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver Date: Wed, 9 Jan 2019 17:05:38 +0100 Message-ID: <20190109160538.GA7273@amd> References: <1545190897-22622-1-git-send-email-Tristram.Ha@microchip.com> <20181219100532.GA2066@nanopsycho> <20181219160857.GA13878@amd> <20181219161532.GA2224@nanopsycho> <20181219172220.GA14258@amd> <63e9dd4b-33c0-a08b-2db1-dea81bdb97ac@denx.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Cc: marex@denx.de, pavel@denx.de, jiri@resnulli.us, andrew@lunn.ch, sergio.paracuellos@gmail.com, f.fainelli@gmail.com, dan.carpenter@oracle.com, vivien.didelot@savoirfairelinux.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org To: Tristram.Ha@microchip.com Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35620 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731647AbfAIQFk (ORCPT ); Wed, 9 Jan 2019 11:05:40 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2018-12-19 22:50:16, Tristram.Ha@microchip.com wrote: > > >>>> This header file makes no sense. Please move the functions into .c > > >>> > > >>> No, that would make code bigger & slower. > > >>> > > >>> It makes sense to me. But I'd add "inline" keyword to make the goal > > >>> explicit. > > >> > > >> 1) It makes no sense to have header files for things like this. The > > >> functions are only used within the single .c file. > > >> > > >> 2) You cannot inline them, as they are used as ops. > > > > > > Ok, sorry for the noise. > >=20 > > If you were to use regmap, this whole boilerplate would go away ... >=20 > Sometimes I am confused about this review process. >=20 > The new code is same as previous code submitted. The old code was accept= ed, > but then there are objections to the new code. Sometimes you just need to reject review comment... It took extremely long to merge this driver; that does not help, either. Good luck, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlw2G9IACgkQMOfwapXb+vLWMwCeMDXT7ill8sE1HgWlxYac/XVD oUAAn3kOxE9m7nu+sHbDkjAvzaUitpOi =TsuD -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--