From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH RESEND] nft_flow_offload: Fix the peer route get from wrong daddr Date: Wed, 9 Jan 2019 20:06:37 +0100 Message-ID: <20190109190637.rhqpp2edpikv3vng@salvia> References: <1547001611-26793-1-git-send-email-wenxu@ucloud.cn> <20190109190358.o2asukctfbijhbqw@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org To: wenxu@ucloud.cn Return-path: Received: from mail.us.es ([193.147.175.20]:51056 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726581AbfAITGl (ORCPT ); Wed, 9 Jan 2019 14:06:41 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id ED486160C07 for ; Wed, 9 Jan 2019 20:06:39 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id DEAF4DA867 for ; Wed, 9 Jan 2019 20:06:39 +0100 (CET) Content-Disposition: inline In-Reply-To: <20190109190358.o2asukctfbijhbqw@salvia> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jan 09, 2019 at 08:03:58PM +0100, Pablo Neira Ayuso wrote: > On Wed, Jan 09, 2019 at 10:40:11AM +0800, wenxu@ucloud.cn wrote: > > From: wenxu > > > > For nat example: > > client 1.1.1.7 ---> 2.2.2.7 which dnat to 10.0.0.7 server > > > > When syn_rcv pkt from server it get the peer(client->server) route > > through daddr = ct->tuplehash[!dir].tuple.dst.u3.ip, the value 2.2.2.7 > > is not correct in this situation. it should be 10.0.0.7 > > ct->tuplehash[dir].tuple.src.u3.ip > > Patch is correct, applied, thanks. BTW, let me rewrite patch title to: netfilter: nft_flow_offload: Fix reverse route lookup I'll also slightly revisit the patch description before applying. Thanks.