* [PATCH] Fix ERROR:do not initialise statics to 0 in af_vsock.c
@ 2019-01-09 23:45 Lepton Wu
2019-01-10 9:59 ` Stefan Hajnoczi
2019-01-16 4:39 ` [PATCH] " David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Lepton Wu @ 2019-01-09 23:45 UTC (permalink / raw)
To: netdev; +Cc: stefanha, decui, jhansen, Lepton Wu
Found by scripts/checkpatch.pl
---
net/vmw_vsock/af_vsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 43a1dec08825..a60df252d3cc 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -505,7 +505,7 @@ static void vsock_pending_work(struct work_struct *work)
static int __vsock_bind_stream(struct vsock_sock *vsk,
struct sockaddr_vm *addr)
{
- static u32 port = 0;
+ static u32 port;
struct sockaddr_vm new_addr;
if (!port)
--
2.20.1.97.g81188d93c3-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix ERROR:do not initialise statics to 0 in af_vsock.c
2019-01-09 23:45 [PATCH] Fix ERROR:do not initialise statics to 0 in af_vsock.c Lepton Wu
@ 2019-01-10 9:59 ` Stefan Hajnoczi
2019-01-10 18:37 ` [PATCH v2] " Lepton Wu
2019-01-16 4:39 ` [PATCH] " David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2019-01-10 9:59 UTC (permalink / raw)
To: Lepton Wu; +Cc: netdev, decui, jhansen
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On Wed, Jan 09, 2019 at 03:45:41PM -0800, Lepton Wu wrote:
> Found by scripts/checkpatch.pl
> ---
Please include your Signed-off-by.
> net/vmw_vsock/af_vsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
> index 43a1dec08825..a60df252d3cc 100644
> --- a/net/vmw_vsock/af_vsock.c
> +++ b/net/vmw_vsock/af_vsock.c
> @@ -505,7 +505,7 @@ static void vsock_pending_work(struct work_struct *work)
> static int __vsock_bind_stream(struct vsock_sock *vsk,
> struct sockaddr_vm *addr)
> {
> - static u32 port = 0;
> + static u32 port;
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] Fix ERROR:do not initialise statics to 0 in af_vsock.c
2019-01-10 9:59 ` Stefan Hajnoczi
@ 2019-01-10 18:37 ` Lepton Wu
0 siblings, 0 replies; 4+ messages in thread
From: Lepton Wu @ 2019-01-10 18:37 UTC (permalink / raw)
To: netdev; +Cc: stefanha, decui, jhansen, Lepton Wu
Found by scripts/checkpatch.pl
Signed-off-by: Lepton Wu <ytht.net@gmail.com>
---
net/vmw_vsock/af_vsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 43a1dec08825..a60df252d3cc 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -505,7 +505,7 @@ static void vsock_pending_work(struct work_struct *work)
static int __vsock_bind_stream(struct vsock_sock *vsk,
struct sockaddr_vm *addr)
{
- static u32 port = 0;
+ static u32 port;
struct sockaddr_vm new_addr;
if (!port)
--
2.20.1.97.g81188d93c3-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix ERROR:do not initialise statics to 0 in af_vsock.c
2019-01-09 23:45 [PATCH] Fix ERROR:do not initialise statics to 0 in af_vsock.c Lepton Wu
2019-01-10 9:59 ` Stefan Hajnoczi
@ 2019-01-16 4:39 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2019-01-16 4:39 UTC (permalink / raw)
To: ytht.net; +Cc: netdev, stefanha, decui, jhansen
From: Lepton Wu <ytht.net@gmail.com>
Date: Wed, 9 Jan 2019 15:45:41 -0800
> Found by scripts/checkpatch.pl
I applied this and pushed out but didn't catch in time that you didn't provide
a properly Signed-off-by: Please do that next time.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-16 4:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-09 23:45 [PATCH] Fix ERROR:do not initialise statics to 0 in af_vsock.c Lepton Wu
2019-01-10 9:59 ` Stefan Hajnoczi
2019-01-10 18:37 ` [PATCH v2] " Lepton Wu
2019-01-16 4:39 ` [PATCH] " David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).