From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR Date: Thu, 10 Jan 2019 09:08:22 -0500 Message-ID: <20190110090804-mutt-send-email-mst@kernel.org> References: <20190102205715.14054-1-mst@redhat.com> <20190102205715.14054-2-mst@redhat.com> <20190109213543-mutt-send-email-mst@kernel.org> <20190110134139.GE1743@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Miguel Ojeda , Nick Desaulniers , LKML , Jason Wang , Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , linux-arch@vger.kernel.org, Network Development , virtualization@lists.linux-foundation.org, Eli F To: Dan Carpenter Return-path: Content-Disposition: inline In-Reply-To: <20190110134139.GE1743@kadam> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Jan 10, 2019 at 04:41:39PM +0300, Dan Carpenter wrote: > On Wed, Jan 09, 2019 at 09:36:41PM -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > > > On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers wrote: > > > > > > > > Also for more context, see: > > > > commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against > > > > dead store elimination") > > > > > > By the way, shouldn't that barrier_data() be directly in compiler.h > > > too, since it is for both gcc & clang? > > > > > > > Reviewed-by: Nick Desaulniers > > > > > > > > + Miguel > > > > Miguel, would you mind taking this into your compiler-attributes tree? > > > > > > Sure, at least we get quickly some linux-next time. > > > > > > BTW why linux-next? shouldn't this go into 5.0 and stable? It's a bugfix after all. > > > > It doesn't hurt to put things in linux-next for a week and then 5.0 and > -stable. Not a lot of testing happens on linux-next, but some does. > > regards, > dan carpenter I misunderstood. Sure that makes sense. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB86BC43387 for ; Thu, 10 Jan 2019 14:08:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 870C4214DA for ; Thu, 10 Jan 2019 14:08:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729097AbfAJOIv (ORCPT ); Thu, 10 Jan 2019 09:08:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43385 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728923AbfAJOIv (ORCPT ); Thu, 10 Jan 2019 09:08:51 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A429A356F8; Thu, 10 Jan 2019 14:08:50 +0000 (UTC) Received: from redhat.com (ovpn-123-72.rdu2.redhat.com [10.10.123.72]) by smtp.corp.redhat.com (Postfix) with SMTP id F33F3601A7; Thu, 10 Jan 2019 14:08:23 +0000 (UTC) Date: Thu, 10 Jan 2019 09:08:22 -0500 From: "Michael S. Tsirkin" To: Dan Carpenter Cc: Miguel Ojeda , Nick Desaulniers , LKML , Jason Wang , Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , linux-arch@vger.kernel.org, Network Development , virtualization@lists.linux-foundation.org, Eli Friedman , Joe Perches , Linus Torvalds , Luc Van Oostenryck , linux-sparse@vger.kernel.org, Eric Christopher Subject: Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR Message-ID: <20190110090804-mutt-send-email-mst@kernel.org> References: <20190102205715.14054-1-mst@redhat.com> <20190102205715.14054-2-mst@redhat.com> <20190109213543-mutt-send-email-mst@kernel.org> <20190110134139.GE1743@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190110134139.GE1743@kadam> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 10 Jan 2019 14:08:51 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Message-ID: <20190110140822.oFAKHBwOpuk73Ls4kx5TaNNgdIP3bZiuS-E66XVu1Sc@z> On Thu, Jan 10, 2019 at 04:41:39PM +0300, Dan Carpenter wrote: > On Wed, Jan 09, 2019 at 09:36:41PM -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > > > On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers wrote: > > > > > > > > Also for more context, see: > > > > commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against > > > > dead store elimination") > > > > > > By the way, shouldn't that barrier_data() be directly in compiler.h > > > too, since it is for both gcc & clang? > > > > > > > Reviewed-by: Nick Desaulniers > > > > > > > > + Miguel > > > > Miguel, would you mind taking this into your compiler-attributes tree? > > > > > > Sure, at least we get quickly some linux-next time. > > > > > > BTW why linux-next? shouldn't this go into 5.0 and stable? It's a bugfix after all. > > > > It doesn't hurt to put things in linux-next for a week and then 5.0 and > -stable. Not a lot of testing happens on linux-next, but some does. > > regards, > dan carpenter I misunderstood. Sure that makes sense. -- MST