From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] ray_cs: fix array out-of-bounds access Date: Thu, 10 Jan 2019 11:32:59 +0000 (UTC) Message-ID: <20190110113300.4CE44608FC@smtp.codeaurora.org> References: <20181220140550.18853-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org To: Colin King Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:47868 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727938AbfAJLdB (ORCPT ); Thu, 10 Jan 2019 06:33:01 -0500 In-Reply-To: <20181220140550.18853-1-colin.king@canonical.com> Sender: netdev-owner@vger.kernel.org List-ID: Colin King wrote: > From: Colin Ian King > > Currently array element org[3] is being accessed, however the array is > only 3 elements in size, so this looks like an off-by-one out-of-bounds > error. Fix this by using org[2], which I believe was the original > intent. > > This issue has existed in the driver back in the pre-git days, so no > idea when it was introduced. > > Detected by CoverityScan, CID#711344 ("Out-of-bounds read") > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 72255c807156 ray_cs: fix array out-of-bounds access -- https://patchwork.kernel.org/patch/10738943/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches