netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] include/linux: Remove duplicate header
@ 2019-01-10 16:01 Brajeswar Ghosh
  2019-01-10 16:01 ` Brajeswar Ghosh
  2019-01-10 19:19 ` Michael S. Tsirkin
  0 siblings, 2 replies; 5+ messages in thread
From: Brajeswar Ghosh @ 2019-01-10 16:01 UTC (permalink / raw)
  To: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung,
	Ariel.Elior, davem, mst, jasowang, john.fastabend, parri.andrea,
	dhowells, ebiederm, james.morris, paul, zohar, mjg59, viro,
	richard_c_haines, sargun
  Cc: jrdr.linux, linux-kernel, netdev, sabyasachi.linux

Remove duplicate headers which are included more than once

Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
---
 include/linux/perf_event.h | 1 -
 include/linux/ptr_ring.h   | 1 -
 include/linux/qed/qed_if.h | 1 -
 include/linux/security.h   | 1 -
 4 files changed, 4 deletions(-)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 53c500f0ca79..8d7a2b65514b 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -53,7 +53,6 @@ struct perf_guest_info_callbacks {
 #include <linux/atomic.h>
 #include <linux/sysfs.h>
 #include <linux/perf_regs.h>
-#include <linux/workqueue.h>
 #include <linux/cgroup.h>
 #include <asm/local.h>
 
diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
index 6894976b54e3..627b7aa067e0 100644
--- a/include/linux/ptr_ring.h
+++ b/include/linux/ptr_ring.h
@@ -26,7 +26,6 @@
 #include <linux/cache.h>
 #include <linux/types.h>
 #include <linux/compiler.h>
-#include <linux/cache.h>
 #include <linux/slab.h>
 #include <asm/errno.h>
 #endif
diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
index a47321a0d572..9ebdb60f605a 100644
--- a/include/linux/qed/qed_if.h
+++ b/include/linux/qed/qed_if.h
@@ -38,7 +38,6 @@
 #include <linux/netdevice.h>
 #include <linux/pci.h>
 #include <linux/skbuff.h>
-#include <linux/types.h>
 #include <asm/byteorder.h>
 #include <linux/io.h>
 #include <linux/compiler.h>
diff --git a/include/linux/security.h b/include/linux/security.h
index ac0ef467d25e..2915ea6a5b77 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -30,7 +30,6 @@
 #include <linux/err.h>
 #include <linux/string.h>
 #include <linux/mm.h>
-#include <linux/fs.h>
 
 struct linux_binprm;
 struct cred;
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] include/linux: Remove duplicate header
  2019-01-10 16:01 [PATCH] include/linux: Remove duplicate header Brajeswar Ghosh
@ 2019-01-10 16:01 ` Brajeswar Ghosh
  2019-01-10 19:19 ` Michael S. Tsirkin
  1 sibling, 0 replies; 5+ messages in thread
From: Brajeswar Ghosh @ 2019-01-10 16:01 UTC (permalink / raw)
  To: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung,
	Ariel.Elior, davem, mst, jasowang, john.fastabend, parri.andrea,
	dhowells, ebiederm, james.morris, paul, zohar, mjg59, viro,
	richard_c_haines, sargun
  Cc: jrdr.linux, linux-kernel, netdev, sabyasachi.linux

Remove duplicate headers which are included more than once

Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
---
 include/linux/perf_event.h | 1 -
 include/linux/ptr_ring.h   | 1 -
 include/linux/qed/qed_if.h | 1 -
 include/linux/security.h   | 1 -
 4 files changed, 4 deletions(-)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 53c500f0ca79..8d7a2b65514b 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -53,7 +53,6 @@ struct perf_guest_info_callbacks {
 #include <linux/atomic.h>
 #include <linux/sysfs.h>
 #include <linux/perf_regs.h>
-#include <linux/workqueue.h>
 #include <linux/cgroup.h>
 #include <asm/local.h>
 
diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
index 6894976b54e3..627b7aa067e0 100644
--- a/include/linux/ptr_ring.h
+++ b/include/linux/ptr_ring.h
@@ -26,7 +26,6 @@
 #include <linux/cache.h>
 #include <linux/types.h>
 #include <linux/compiler.h>
-#include <linux/cache.h>
 #include <linux/slab.h>
 #include <asm/errno.h>
 #endif
diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
index a47321a0d572..9ebdb60f605a 100644
--- a/include/linux/qed/qed_if.h
+++ b/include/linux/qed/qed_if.h
@@ -38,7 +38,6 @@
 #include <linux/netdevice.h>
 #include <linux/pci.h>
 #include <linux/skbuff.h>
-#include <linux/types.h>
 #include <asm/byteorder.h>
 #include <linux/io.h>
 #include <linux/compiler.h>
diff --git a/include/linux/security.h b/include/linux/security.h
index ac0ef467d25e..2915ea6a5b77 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -30,7 +30,6 @@
 #include <linux/err.h>
 #include <linux/string.h>
 #include <linux/mm.h>
-#include <linux/fs.h>
 
 struct linux_binprm;
 struct cred;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] include/linux: Remove duplicate header
  2019-01-10 16:01 [PATCH] include/linux: Remove duplicate header Brajeswar Ghosh
  2019-01-10 16:01 ` Brajeswar Ghosh
@ 2019-01-10 19:19 ` Michael S. Tsirkin
  2019-01-10 19:19   ` Michael S. Tsirkin
  2019-01-30 14:30   ` Brajeswar Ghosh
  1 sibling, 2 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2019-01-10 19:19 UTC (permalink / raw)
  To: Brajeswar Ghosh
  Cc: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung,
	Ariel.Elior, davem, jasowang, john.fastabend, parri.andrea,
	dhowells, ebiederm, james.morris, paul, zohar, mjg59, viro,
	richard_c_haines, sargun, jrdr.linux, linux-kernel, netdev,
	sabyasachi.linux

On Thu, Jan 10, 2019 at 09:31:14PM +0530, Brajeswar Ghosh wrote:
> Remove duplicate headers which are included more than once
> 
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> ---
>  include/linux/perf_event.h | 1 -
>  include/linux/ptr_ring.h   | 1 -
>  include/linux/qed/qed_if.h | 1 -
>  include/linux/security.h   | 1 -
>  4 files changed, 4 deletions(-)
> 
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 53c500f0ca79..8d7a2b65514b 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -53,7 +53,6 @@ struct perf_guest_info_callbacks {
>  #include <linux/atomic.h>
>  #include <linux/sysfs.h>
>  #include <linux/perf_regs.h>
> -#include <linux/workqueue.h>
>  #include <linux/cgroup.h>
>  #include <asm/local.h>
>  
> diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
> index 6894976b54e3..627b7aa067e0 100644
> --- a/include/linux/ptr_ring.h
> +++ b/include/linux/ptr_ring.h
> @@ -26,7 +26,6 @@
>  #include <linux/cache.h>
>  #include <linux/types.h>
>  #include <linux/compiler.h>
> -#include <linux/cache.h>
>  #include <linux/slab.h>
>  #include <asm/errno.h>
>  #endif


Acked-by: Michael S. Tsirkin <mst@redhat.com>


Pls merge through the trivial tree or similar.


> diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
> index a47321a0d572..9ebdb60f605a 100644
> --- a/include/linux/qed/qed_if.h
> +++ b/include/linux/qed/qed_if.h
> @@ -38,7 +38,6 @@
>  #include <linux/netdevice.h>
>  #include <linux/pci.h>
>  #include <linux/skbuff.h>
> -#include <linux/types.h>
>  #include <asm/byteorder.h>
>  #include <linux/io.h>
>  #include <linux/compiler.h>
> diff --git a/include/linux/security.h b/include/linux/security.h
> index ac0ef467d25e..2915ea6a5b77 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -30,7 +30,6 @@
>  #include <linux/err.h>
>  #include <linux/string.h>
>  #include <linux/mm.h>
> -#include <linux/fs.h>
>  
>  struct linux_binprm;
>  struct cred;
> -- 
> 2.17.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] include/linux: Remove duplicate header
  2019-01-10 19:19 ` Michael S. Tsirkin
@ 2019-01-10 19:19   ` Michael S. Tsirkin
  2019-01-30 14:30   ` Brajeswar Ghosh
  1 sibling, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2019-01-10 19:19 UTC (permalink / raw)
  To: Brajeswar Ghosh
  Cc: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung,
	Ariel.Elior, davem, jasowang, john.fastabend, parri.andrea,
	dhowells, ebiederm, james.morris, paul, zohar, mjg59, viro,
	richard_c_haines, sargun, jrdr.linux, linux-kernel, netdev,
	sabyasachi.linux

On Thu, Jan 10, 2019 at 09:31:14PM +0530, Brajeswar Ghosh wrote:
> Remove duplicate headers which are included more than once
> 
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> ---
>  include/linux/perf_event.h | 1 -
>  include/linux/ptr_ring.h   | 1 -
>  include/linux/qed/qed_if.h | 1 -
>  include/linux/security.h   | 1 -
>  4 files changed, 4 deletions(-)
> 
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 53c500f0ca79..8d7a2b65514b 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -53,7 +53,6 @@ struct perf_guest_info_callbacks {
>  #include <linux/atomic.h>
>  #include <linux/sysfs.h>
>  #include <linux/perf_regs.h>
> -#include <linux/workqueue.h>
>  #include <linux/cgroup.h>
>  #include <asm/local.h>
>  
> diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
> index 6894976b54e3..627b7aa067e0 100644
> --- a/include/linux/ptr_ring.h
> +++ b/include/linux/ptr_ring.h
> @@ -26,7 +26,6 @@
>  #include <linux/cache.h>
>  #include <linux/types.h>
>  #include <linux/compiler.h>
> -#include <linux/cache.h>
>  #include <linux/slab.h>
>  #include <asm/errno.h>
>  #endif


Acked-by: Michael S. Tsirkin <mst@redhat.com>


Pls merge through the trivial tree or similar.


> diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
> index a47321a0d572..9ebdb60f605a 100644
> --- a/include/linux/qed/qed_if.h
> +++ b/include/linux/qed/qed_if.h
> @@ -38,7 +38,6 @@
>  #include <linux/netdevice.h>
>  #include <linux/pci.h>
>  #include <linux/skbuff.h>
> -#include <linux/types.h>
>  #include <asm/byteorder.h>
>  #include <linux/io.h>
>  #include <linux/compiler.h>
> diff --git a/include/linux/security.h b/include/linux/security.h
> index ac0ef467d25e..2915ea6a5b77 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -30,7 +30,6 @@
>  #include <linux/err.h>
>  #include <linux/string.h>
>  #include <linux/mm.h>
> -#include <linux/fs.h>
>  
>  struct linux_binprm;
>  struct cred;
> -- 
> 2.17.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] include/linux: Remove duplicate header
  2019-01-10 19:19 ` Michael S. Tsirkin
  2019-01-10 19:19   ` Michael S. Tsirkin
@ 2019-01-30 14:30   ` Brajeswar Ghosh
  1 sibling, 0 replies; 5+ messages in thread
From: Brajeswar Ghosh @ 2019-01-30 14:30 UTC (permalink / raw)
  To: Michael S. Tsirkin
  Cc: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung,
	Ariel.Elior, davem, jasowang, john fastabend, Andrea Parri,
	dhowells, ebiederm, james.morris, Paul Moore, zohar, mjg59, viro,
	Richard Haines, Sargun Dhillon, Souptick Joarder, linux-kernel,
	netdev, Sabyasachi Gupta

On Fri, Jan 11, 2019 at 12:50 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Thu, Jan 10, 2019 at 09:31:14PM +0530, Brajeswar Ghosh wrote:
> > Remove duplicate headers which are included more than once
> >
> > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> > ---
> >  include/linux/perf_event.h | 1 -
> >  include/linux/ptr_ring.h   | 1 -
> >  include/linux/qed/qed_if.h | 1 -
> >  include/linux/security.h   | 1 -
> >  4 files changed, 4 deletions(-)
> >
> > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> > index 53c500f0ca79..8d7a2b65514b 100644
> > --- a/include/linux/perf_event.h
> > +++ b/include/linux/perf_event.h
> > @@ -53,7 +53,6 @@ struct perf_guest_info_callbacks {
> >  #include <linux/atomic.h>
> >  #include <linux/sysfs.h>
> >  #include <linux/perf_regs.h>
> > -#include <linux/workqueue.h>
> >  #include <linux/cgroup.h>
> >  #include <asm/local.h>
> >
> > diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
> > index 6894976b54e3..627b7aa067e0 100644
> > --- a/include/linux/ptr_ring.h
> > +++ b/include/linux/ptr_ring.h
> > @@ -26,7 +26,6 @@
> >  #include <linux/cache.h>
> >  #include <linux/types.h>
> >  #include <linux/compiler.h>
> > -#include <linux/cache.h>
> >  #include <linux/slab.h>
> >  #include <asm/errno.h>
> >  #endif
>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
>
> Pls merge through the trivial tree or similar.

If no further comment, can we get this patch in queue for 5.1 ?

>
>
> > diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
> > index a47321a0d572..9ebdb60f605a 100644
> > --- a/include/linux/qed/qed_if.h
> > +++ b/include/linux/qed/qed_if.h
> > @@ -38,7 +38,6 @@
> >  #include <linux/netdevice.h>
> >  #include <linux/pci.h>
> >  #include <linux/skbuff.h>
> > -#include <linux/types.h>
> >  #include <asm/byteorder.h>
> >  #include <linux/io.h>
> >  #include <linux/compiler.h>
> > diff --git a/include/linux/security.h b/include/linux/security.h
> > index ac0ef467d25e..2915ea6a5b77 100644
> > --- a/include/linux/security.h
> > +++ b/include/linux/security.h
> > @@ -30,7 +30,6 @@
> >  #include <linux/err.h>
> >  #include <linux/string.h>
> >  #include <linux/mm.h>
> > -#include <linux/fs.h>
> >
> >  struct linux_binprm;
> >  struct cred;
> > --
> > 2.17.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-01-30 14:30 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-10 16:01 [PATCH] include/linux: Remove duplicate header Brajeswar Ghosh
2019-01-10 16:01 ` Brajeswar Ghosh
2019-01-10 19:19 ` Michael S. Tsirkin
2019-01-10 19:19   ` Michael S. Tsirkin
2019-01-30 14:30   ` Brajeswar Ghosh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).