From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031 Date: Thu, 10 Jan 2019 13:24:46 -0800 Message-ID: <20190110212446.GN5540@atomide.com> References: <6d3b1dce-7633-51a1-0556-97cd03304c2c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Lunn , Florian Fainelli , David Miller , "netdev@vger.kernel.org" , Sekhar Nori To: Heiner Kallweit Return-path: Received: from muru.com ([72.249.23.125]:33186 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728385AbfAJVYt (ORCPT ); Thu, 10 Jan 2019 16:24:49 -0500 Content-Disposition: inline In-Reply-To: <6d3b1dce-7633-51a1-0556-97cd03304c2c@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: * Heiner Kallweit [190110 19:22]: > So far genphy_soft_reset was used automatically if the PHY driver > didn't implement the soft_reset callback. This changed with the > mentioned commit and broke KSZ9031. To fix this configure the > KSZ9031 PHY driver to use genphy_soft_reset. > > Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") > Reported-by: Tony Lindgren > Signed-off-by: Heiner Kallweit Thanks this fixes the regression for me: Tested-by: Tony Lindgren > --- > drivers/net/phy/micrel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index c33384710..7828d17f0 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -1070,6 +1070,7 @@ static struct phy_driver ksphy_driver[] = { > .driver_data = &ksz9021_type, > .probe = kszphy_probe, > .config_init = ksz9031_config_init, > + .soft_reset = genphy_soft_reset, > .read_status = ksz9031_read_status, > .ack_interrupt = kszphy_ack_interrupt, > .config_intr = kszphy_config_intr, > -- > 2.20.1 >