Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: wangyunjian <wangyunjian@huawei.com>
Cc: netdev@vger.kernel.org, xudingke@huawei.com
Subject: Re: [PATCH net] bridge: Fix ethernet header pointer before check skb forwardable
Date: Sat, 12 Jan 2019 15:54:49 +0100	[thread overview]
Message-ID: <20190112145449.GB16179@lunn.ch> (raw)
In-Reply-To: <1547288907-18108-1-git-send-email-wangyunjian@huawei.com>

On Sat, Jan 12, 2019 at 06:28:27PM +0800, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> The skb header should be set to ethernet header before using
> is_skb_forwardable(including dev->hard_header_len length).

Hi Yunjian

I don't see any recent changes in this code. Do you know why this is
needed now, yet it seemed to work before? Do you have a fixes: tag for
where it broke?

Thanks
	Andrew

  reply	other threads:[~2019-01-12 14:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-12 10:28 [PATCH net] bridge: Fix ethernet header pointer before check skb forwardable wangyunjian
2019-01-12 14:54 ` Andrew Lunn [this message]
2019-01-14  4:05   ` wangyunjian
2019-01-14 13:51     ` Andrew Lunn
2019-01-14 14:04       ` Nikolay Aleksandrov
2019-01-15  3:08         ` wangyunjian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190112145449.GB16179@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=netdev@vger.kernel.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox