From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 1/1] bonding: fix PACKET_ORIGDEV regression on bonding masters Date: Sun, 13 Jan 2019 15:03:55 -0800 (PST) Message-ID: <20190113.150355.1753998293477839740.davem@davemloft.net> References: <20190107162946.13072-1-soltys@ziu.info> <20190107162946.13072-2-soltys@ziu.info> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jay.vosburgh@canonical.com, vincent@bernat.ch, maheshb@google.com, maze@google.com, chonggangli@google.com To: soltys@ziu.info Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:58370 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726471AbfAMXD6 (ORCPT ); Sun, 13 Jan 2019 18:03:58 -0500 In-Reply-To: <20190107162946.13072-2-soltys@ziu.info> Sender: netdev-owner@vger.kernel.org List-ID: From: Michal Soltys Date: Mon, 7 Jan 2019 17:29:46 +0100 > This patch reverts: > > b89f04c61efe bonding: deliver link-local packets with skb->dev set to link that packets arrived on > > And its subsequent fixups: > > 6a9e461f6fe4 bonding: pass link-local packets to bonding master also. > 0f3b914c9cfc bonding: fix warning message > > The intended functionality of the original patch (as explained by its > author) has been available in the kernel since v2.6.21-350-g80feaacb8a64 > via PACKET_ORIGDEV socket option. The patch also broke that feature, as > it's now no longer possible to get the original incoming device. Quoting > the report: > >> Unfortunately, this doesn't completely restore the previous >> functionality as PACKET_ORIGDEV is broken for the copy: the original >> interface is lost through the call to netif_rx(). A LLDP daemon >> listening to the master interface won't get the original interface like >> it was able to before 4.12. > > The patch reverts to pre-b89f04c61efe state, so: > > - both master and original (via PACKET_ORIGDEV) devices are available > when listening on the master > - original device is available when listening directly on one of its > slaves > > Reported-by: Vincent Bernat > Signed-off-by: Michal Soltys Google folks I want to hear what you have to say about all of this. Thank you.