From: David Miller <davem@davemloft.net>
To: dcaratti@redhat.com
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
netdev@vger.kernel.org, amir@vadai.me
Subject: Re: [PATCH net] net/sched: act_tunnel_key: fix memory leak in case of action replace
Date: Tue, 15 Jan 2019 21:40:07 -0800 (PST) [thread overview]
Message-ID: <20190115.214007.54305144538440337.davem@davemloft.net> (raw)
In-Reply-To: <61be610db89454f4ad2a02e18e213931dda26963.1547147773.git.dcaratti@redhat.com>
From: Davide Caratti <dcaratti@redhat.com>
Date: Thu, 10 Jan 2019 20:21:02 +0100
> running the following TDC test cases:
>
> 7afc - Replace tunnel_key set action with all parameters
> 364d - Replace tunnel_key set action with all parameters and cookie
>
> it's possible to trigger kmemleak warnings like:
...
> when the tunnel_key action is replaced, the kernel forgets to release the
> dst metadata: ensure they are released by tunnel_key_init(), the same way
> it's done in tunnel_key_release().
>
> Fixes: d0f6dd8a914f4 ("net/sched: Introduce act_tunnel_key")
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2019-01-16 5:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 19:21 [PATCH net] net/sched: act_tunnel_key: fix memory leak in case of action replace Davide Caratti
2019-01-11 22:25 ` Cong Wang
2019-01-16 5:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115.214007.54305144538440337.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amir@vadai.me \
--cc=dcaratti@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).