netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] net: phy: fixed-phy: Drop GPIO from fixed_phy_add()
Date: Tue, 15 Jan 2019 02:48:42 +0100	[thread overview]
Message-ID: <20190115014842.GD8882@lunn.ch> (raw)
In-Reply-To: <20190114080225.3805-1-linus.walleij@linaro.org>

>  struct phy_device *fixed_phy_register(unsigned int irq,
>  				      struct fixed_phy_status *status,
> -				      int link_gpio,
>  				      struct device_node *np)
>  {
>  	struct fixed_mdio_bus *fmb = &platform_fmb;
>  	struct phy_device *phy;
> +	struct gpio_desc *gpiod = NULL;
>  	int phy_addr;
>  	int ret;

Hi Linus

Networking code uses reverse christmas tree. Please move gpiod higher
up by one line.

Thanks
	Andrew

      parent reply	other threads:[~2019-01-15  1:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  8:02 [PATCH] net: phy: fixed-phy: Drop GPIO from fixed_phy_add() Linus Walleij
2019-01-14 14:15 ` Andrew Lunn
2019-01-15  1:46 ` Andrew Lunn
2019-01-15  1:48 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190115014842.GD8882@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).