From: Samu Nuutamo <samu.nuutamo@vincit.fi>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: Regression: mv88e6xxx packet loss after 4.18's PHYLINK merge
Date: Tue, 15 Jan 2019 10:15:48 +0200 [thread overview]
Message-ID: <20190115081548.GA3819@samu-ThinkPad-T480s> (raw)
In-Reply-To: <48924158-5ce6-41b5-18af-c4aff205311d@gmail.com>
On Mon, Jan 14, 2019 at 10:03:57AM -0800, Florian Fainelli wrote:
> Samu, is this fixed link using a GPIO to determine the link state? Does
> this patch help at all?
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c
> b/drivers/net/dsa/mv88e6xxx/chip.c
> index 8a517d8fb9d1..9dedb9b22c13 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -721,7 +721,7 @@ static void mv88e6xxx_mac_config(struct dsa_switch
> *ds, int port,
> return;
>
> if (mode == MLO_AN_FIXED) {
> - link = LINK_FORCED_UP;
> + link = state->link;
> speed = state->speed;
> duplex = state->duplex;
> } else if (!mv88e6xxx_phy_is_internal(ds, port)) {
Hi Florian,
I'm not 100% sure but it looks like GPIO is not used for that purpose.
I tested your patch but unfortunately it didn't work as the link keeps
cycling down/up.
- Samu
next prev parent reply other threads:[~2019-01-15 8:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 11:34 Regression: mv88e6xxx packet loss after 4.18's PHYLINK merge Samu Nuutamo
2019-01-14 14:23 ` Andrew Lunn
2019-01-14 18:03 ` Florian Fainelli
2019-01-15 8:15 ` Samu Nuutamo [this message]
2019-01-17 2:29 ` Andrew Lunn
2019-01-17 11:37 ` Samu Nuutamo
2019-01-23 2:10 ` Andrew Lunn
2019-01-23 7:16 ` Samu Nuutamo
2019-01-25 19:00 ` Florian Fainelli
2019-01-25 19:15 ` Russell King - ARM Linux admin
2019-01-17 15:46 ` Samu Nuutamo
2019-01-21 17:52 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115081548.GA3819@samu-ThinkPad-T480s \
--to=samu.nuutamo@vincit.fi \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox