From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samu Nuutamo <samu.nuutamo@vincit.fi>
Subject: Re: Regression: mv88e6xxx packet loss after 4.18's PHYLINK merge
Date: Tue, 15 Jan 2019 10:15:48 +0200
Message-ID: <20190115081548.GA3819@samu-ThinkPad-T480s>
References: <20190114113444.GB16632@samu-ThinkPad-T480s>
 <20190114142358.GJ4635@lunn.ch>
 <48924158-5ce6-41b5-18af-c4aff205311d@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Lunn <andrew@lunn.ch>, netdev@vger.kernel.org,
        Vivien Didelot <vivien.didelot@gmail.com>,
        "David S. Miller" <davem@davemloft.net>
To: Florian Fainelli <f.fainelli@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-lf1-f43.google.com ([209.85.167.43]:42499 "EHLO
        mail-lf1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726022AbfAOIPx (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 15 Jan 2019 03:15:53 -0500
Received: by mail-lf1-f43.google.com with SMTP id l10so1313085lfh.9
        for <netdev@vger.kernel.org>; Tue, 15 Jan 2019 00:15:52 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <48924158-5ce6-41b5-18af-c4aff205311d@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Jan 14, 2019 at 10:03:57AM -0800, Florian Fainelli wrote:
> Samu, is this fixed link using a GPIO to determine the link state? Does
> this patch help at all?
> 
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c
> b/drivers/net/dsa/mv88e6xxx/chip.c
> index 8a517d8fb9d1..9dedb9b22c13 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -721,7 +721,7 @@ static void mv88e6xxx_mac_config(struct dsa_switch
> *ds, int port,
>                 return;
> 
>         if (mode == MLO_AN_FIXED) {
> -               link = LINK_FORCED_UP;
> +               link = state->link;
>                 speed = state->speed;
>                 duplex = state->duplex;
>         } else if (!mv88e6xxx_phy_is_internal(ds, port)) {

Hi Florian,

I'm not 100% sure but it looks like GPIO is not used for that purpose.
I tested your patch but unfortunately it didn't work as the link keeps
cycling down/up.

- Samu