From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [RFC iproute2-next] devlink: add info subcommand Date: Tue, 15 Jan 2019 09:20:11 +0100 Message-ID: <20190115082011.GB2290@nanopsycho> References: <20190115005009.16025-1-jakub.kicinski@netronome.com> <20190115005009.16025-8-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com To: Jakub Kicinski Return-path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:41728 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbfAOI2p (ORCPT ); Tue, 15 Jan 2019 03:28:45 -0500 Received: by mail-wr1-f67.google.com with SMTP id x10so1861769wrs.8 for ; Tue, 15 Jan 2019 00:28:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190115005009.16025-8-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: [...] > static void help(void) > { > pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n" > " devlink [ -f[orce] ] -b[atch] filename\n" >- "where OBJECT := { dev | port | sb | monitor | dpipe | resource | region }\n" >+ "where OBJECT := { dev | port | sb | monitor | dpipe | resource | region | info }\n" I think that "info" should be nested under "dev". It is related to dev. Maybe it even does not have to be a separate command and can be a nested attribute to existing DEVLINK_CMD_GET cmd. > " OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] | -v[erbose] }\n"); > }