From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [RFC net-next 1/6] devlink: add device information API Date: Tue, 15 Jan 2019 09:41:34 -0800 Message-ID: <20190115094134.4c6fd9f2@cakuba.netronome.com> References: <20190115005009.16025-1-jakub.kicinski@netronome.com> <20190115005009.16025-2-jakub.kicinski@netronome.com> <20190115101512.GD2290@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com To: Jiri Pirko Return-path: Received: from mail-qt1-f193.google.com ([209.85.160.193]:46831 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729035AbfAORlj (ORCPT ); Tue, 15 Jan 2019 12:41:39 -0500 Received: by mail-qt1-f193.google.com with SMTP id y20so3846264qtm.13 for ; Tue, 15 Jan 2019 09:41:39 -0800 (PST) In-Reply-To: <20190115101512.GD2290@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 15 Jan 2019 11:15:12 +0100, Jiri Pirko wrote: > Tue, Jan 15, 2019 at 01:50:03AM CET, jakub.kicinski@netronome.com wrote: > >+static int devlink_nl_info_sn_fill(struct sk_buff *msg, struct devlink *devlink, > >+ struct netlink_ext_ack *extack) > >+{ > >+ unsigned char sn[32]; > > :/ Not good to have number directly here. > > >+ size_t len = 0; > >+ int err; > >+ > >+ if (!devlink->ops->serial_get) > >+ return 0; > >+ > >+ err = devlink->ops->serial_get(devlink, sn, ARRAY_SIZE(sn), &len, > >+ extack); > > Maybe it would be good to have a helper to fill this as well. That way, > driver could pass buffer of any length and helper would encode it into > skb. Ack, will do. IMHO it's a bit of an overkill, one could "safely assume" serial number won't be longer than 32 bytes.. :) But no problem, will do! > >+ if (err) > >+ return err; > >+ > >+ return nla_put(msg, DEVLINK_ATTR_INFO_SERIAL_NUMBER, len, sn); > >+}