From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [RFC net-next 1/6] devlink: add device information API
Date: Tue, 15 Jan 2019 11:15:12 +0100 [thread overview]
Message-ID: <20190115101512.GD2290@nanopsycho> (raw)
In-Reply-To: <20190115005009.16025-2-jakub.kicinski@netronome.com>
Tue, Jan 15, 2019 at 01:50:03AM CET, jakub.kicinski@netronome.com wrote:
[...]
>+static int devlink_nl_info_sn_fill(struct sk_buff *msg, struct devlink *devlink,
>+ struct netlink_ext_ack *extack)
>+{
>+ unsigned char sn[32];
:/ Not good to have number directly here.
>+ size_t len = 0;
>+ int err;
>+
>+ if (!devlink->ops->serial_get)
>+ return 0;
>+
>+ err = devlink->ops->serial_get(devlink, sn, ARRAY_SIZE(sn), &len,
>+ extack);
Maybe it would be good to have a helper to fill this as well. That way,
driver could pass buffer of any length and helper would encode it into
skb.
>+ if (err)
>+ return err;
>+
>+ return nla_put(msg, DEVLINK_ATTR_INFO_SERIAL_NUMBER, len, sn);
>+}
[...]
next prev parent reply other threads:[~2019-01-15 10:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 0:50 [RFC net-next 0/6] devlink: add device (driver) information API Jakub Kicinski
2019-01-15 0:50 ` [RFC net-next 1/6] devlink: add device " Jakub Kicinski
2019-01-15 10:15 ` Jiri Pirko [this message]
2019-01-15 17:41 ` Jakub Kicinski
2019-01-15 20:00 ` Andrew Lunn
2019-01-15 21:42 ` Jakub Kicinski
2019-01-15 0:50 ` [RFC net-next 2/6] devlink: add version reporting API Jakub Kicinski
2019-01-15 10:12 ` Jiri Pirko
2019-01-15 0:50 ` [RFC net-next 3/6] nfp: devlink: report serial number Jakub Kicinski
2019-01-15 0:50 ` [RFC net-next 4/6] nfp: devlink: report fixed versions Jakub Kicinski
2019-01-15 10:18 ` Jiri Pirko
2019-01-15 18:09 ` Jakub Kicinski
2019-01-15 0:50 ` [RFC net-next 5/6] nfp: nsp: add support for versions command Jakub Kicinski
2019-01-15 0:50 ` [RFC net-next 6/6] nfp: devlink: report the running and flashed versions Jakub Kicinski
2019-01-15 0:50 ` [RFC iproute2-next] devlink: add info subcommand Jakub Kicinski
2019-01-15 8:20 ` Jiri Pirko
2019-01-15 14:00 ` Andrew Lunn
2019-01-15 14:07 ` Jiri Pirko
2019-01-15 17:58 ` Jakub Kicinski
2019-01-15 17:53 ` Jakub Kicinski
2019-01-15 18:05 ` Jiri Pirko
2019-01-15 18:32 ` Jakub Kicinski
2019-01-15 1:00 ` [RFC net-next 0/6] devlink: add device (driver) information API Florian Fainelli
2019-01-15 1:18 ` Andrew Lunn
2019-01-15 1:33 ` Jakub Kicinski
2019-01-15 1:57 ` Andrew Lunn
2019-01-15 3:27 ` Jakub Kicinski
2019-01-15 7:36 ` Michal Kubecek
2019-01-15 8:12 ` Jiri Pirko
2019-01-15 19:30 ` Jonathan Lemon
2019-01-15 21:06 ` Jakub Kicinski
2019-01-15 23:41 ` Jiri Pirko
2019-01-16 19:00 ` Jonathan Lemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115101512.GD2290@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).