From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [RFC net-next 1/6] devlink: add device information API
Date: Tue, 15 Jan 2019 11:15:12 +0100
Message-ID: <20190115101512.GD2290@nanopsycho>
References: <20190115005009.16025-1-jakub.kicinski@netronome.com>
 <20190115005009.16025-2-jakub.kicinski@netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem@davemloft.net, netdev@vger.kernel.org,
        oss-drivers@netronome.com
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm1-f65.google.com ([209.85.128.65]:54083 "EHLO
        mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726077AbfAOKXq (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 15 Jan 2019 05:23:46 -0500
Received: by mail-wm1-f65.google.com with SMTP id d15so2690569wmb.3
        for <netdev@vger.kernel.org>; Tue, 15 Jan 2019 02:23:45 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20190115005009.16025-2-jakub.kicinski@netronome.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Tue, Jan 15, 2019 at 01:50:03AM CET, jakub.kicinski@netronome.com wrote:

[...]

>+static int devlink_nl_info_sn_fill(struct sk_buff *msg, struct devlink *devlink,
>+				   struct netlink_ext_ack *extack)
>+{
>+	unsigned char sn[32];

:/ Not good to have number directly here.

>+	size_t len = 0;
>+	int err;
>+
>+	if (!devlink->ops->serial_get)
>+		return 0;
>+
>+	err = devlink->ops->serial_get(devlink, sn, ARRAY_SIZE(sn), &len,
>+				       extack);

Maybe it would be good to have a helper to fill this as well. That way,
driver could pass buffer of any length and helper would encode it into
skb.



>+	if (err)
>+		return err;
>+
>+	return nla_put(msg, DEVLINK_ATTR_INFO_SERIAL_NUMBER, len, sn);
>+}

[...]