From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [RFC net-next 1/6] devlink: add device information API Date: Tue, 15 Jan 2019 13:42:42 -0800 Message-ID: <20190115134242.0d9c01b4@cakuba.netronome.com> References: <20190115005009.16025-1-jakub.kicinski@netronome.com> <20190115005009.16025-2-jakub.kicinski@netronome.com> <20190115101512.GD2290@nanopsycho> <20190115094134.4c6fd9f2@cakuba.netronome.com> <20190115200012.GA26788@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Jiri Pirko , davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com To: Andrew Lunn Return-path: Received: from mail-qt1-f195.google.com ([209.85.160.195]:40446 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729432AbfAOVmr (ORCPT ); Tue, 15 Jan 2019 16:42:47 -0500 Received: by mail-qt1-f195.google.com with SMTP id k12so4790434qtf.7 for ; Tue, 15 Jan 2019 13:42:46 -0800 (PST) In-Reply-To: <20190115200012.GA26788@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 15 Jan 2019 21:00:12 +0100, Andrew Lunn wrote: > > Ack, will do. IMHO it's a bit of an overkill, one could "safely > > assume" serial number won't be longer than 32 bytes.. :) But no > > problem, will do! > > A git hash is 40 bytes. It's 20 bytes, this is in binary form. Plus serial numbers are unique ID of the device, not sure how hash would work there ;) But I take your point, I'll redo this bit! :)