From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH bpf v3] tools/bpf: properly account for libbfd variations Date: Tue, 15 Jan 2019 14:06:20 -0800 Message-ID: <20190115140620.16260b8c@cakuba.netronome.com> References: <20190115135510.0df374a1@cakuba.netronome.com> <20190115220327.171608-1-sdf@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, quentin.monnet@netronome.com To: Stanislav Fomichev Return-path: Received: from mail-qk1-f196.google.com ([209.85.222.196]:37656 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390956AbfAOWG0 (ORCPT ); Tue, 15 Jan 2019 17:06:26 -0500 Received: by mail-qk1-f196.google.com with SMTP id g125so2562995qke.4 for ; Tue, 15 Jan 2019 14:06:25 -0800 (PST) In-Reply-To: <20190115220327.171608-1-sdf@google.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 15 Jan 2019 14:03:27 -0800, Stanislav Fomichev wrote: > On some platforms, in order to link against libbfd, we need to > link against liberty and even possibly libz. Account for that > in the bpftool Makefile. We now have proper feature detection > for each case, so handle each one separately. > > See recent commit 14541b1e7e72 ("perf build: Don't unconditionally link the > libbfd feature test to -liberty and -lz") where I fixed feature > detection. > > v2 (addressed Jakub's nits): > * better syntax for 'else ifeq' > * no space between ifeq args > v3: > * use LIBS, not EXTLIBS for -DHAVE_LIBBFD_SUPPORT > > Fixes: 29a9c10e4110 ("bpftool: make libbfd optional") > Signed-off-by: Stanislav Fomichev Acked-by: Jakub Kicinski Thanks!!