From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [RFC iproute2-next] devlink: add info subcommand Date: Tue, 15 Jan 2019 15:07:29 +0100 Message-ID: <20190115140729.GF2290@nanopsycho> References: <20190115005009.16025-1-jakub.kicinski@netronome.com> <20190115005009.16025-8-jakub.kicinski@netronome.com> <20190115082011.GB2290@nanopsycho> <20190115140046.GG19687@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com To: Andrew Lunn Return-path: Received: from mail-wm1-f67.google.com ([209.85.128.67]:36663 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728612AbfAOOQD (ORCPT ); Tue, 15 Jan 2019 09:16:03 -0500 Received: by mail-wm1-f67.google.com with SMTP id p6so3371178wmc.1 for ; Tue, 15 Jan 2019 06:16:01 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190115140046.GG19687@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: Tue, Jan 15, 2019 at 03:00:46PM CET, andrew@lunn.ch wrote: >On Tue, Jan 15, 2019 at 09:20:11AM +0100, Jiri Pirko wrote: >> [...] >> >> > static void help(void) >> > { >> > pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n" >> > " devlink [ -f[orce] ] -b[atch] filename\n" >> >- "where OBJECT := { dev | port | sb | monitor | dpipe | resource | region }\n" >> >+ "where OBJECT := { dev | port | sb | monitor | dpipe | resource | region | info }\n" >> >> I think that "info" should be nested under "dev". It is related to dev. >> Maybe it even does not have to be a separate command and can be a nested >> attribute to existing DEVLINK_CMD_GET cmd. > >Hi Jiri > >Not that i agree devlink is the right place for this, but i think it Where else to put it? >probably needs to be nested both under dev and port. I could have a >line card implementing a port which has version information, as well >as version information for the backplane which would be under dev. Okay. Sounds good to me. > > Andrew