* [PATCH net] net: bpfilter: change section name of bpfilter UMH blob.
@ 2019-01-15 16:35 Taehee Yoo
2019-01-16 23:47 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Taehee Yoo @ 2019-01-15 16:35 UTC (permalink / raw)
To: davem, netdev; +Cc: daniel, ast, sfr, ap420073
The section of bpfilter UMH blob is the ".bpfilter_umh". but this is not
an explicit section. so linking warning occurred at compile time for the
powerpc.
So, this patch makes use of the ".rodata" instead of the ".bpfilter_umh".
Config condition:
CONFIG_BPFILTER=y
CONFIG_BPFILTER_UMH=y
Result:
ld: warning: orphan section `.bpfilter_umh' from
`net/bpfilter/bpfilter_umh_blob.o' being placed in section `.bpfilter_umh'
Fixes: 61fbf5933d42 ("net: bpfilter: restart bpfilter_umh when error occurred")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
net/bpfilter/bpfilter_umh_blob.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bpfilter/bpfilter_umh_blob.S b/net/bpfilter/bpfilter_umh_blob.S
index 7f1c521dcc2f..9ea6100dca87 100644
--- a/net/bpfilter/bpfilter_umh_blob.S
+++ b/net/bpfilter/bpfilter_umh_blob.S
@@ -1,5 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0 */
- .section .bpfilter_umh, "a"
+ .section .rodata, "a"
.global bpfilter_umh_start
bpfilter_umh_start:
.incbin "net/bpfilter/bpfilter_umh"
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: bpfilter: change section name of bpfilter UMH blob.
2019-01-15 16:35 [PATCH net] net: bpfilter: change section name of bpfilter UMH blob Taehee Yoo
@ 2019-01-16 23:47 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-16 23:47 UTC (permalink / raw)
To: ap420073; +Cc: netdev, daniel, ast, sfr
From: Taehee Yoo <ap420073@gmail.com>
Date: Wed, 16 Jan 2019 01:35:22 +0900
> The section of bpfilter UMH blob is the ".bpfilter_umh". but this is not
> an explicit section. so linking warning occurred at compile time for the
> powerpc.
> So, this patch makes use of the ".rodata" instead of the ".bpfilter_umh".
>
> Config condition:
>
> CONFIG_BPFILTER=y
> CONFIG_BPFILTER_UMH=y
>
> Result:
>
> ld: warning: orphan section `.bpfilter_umh' from
> `net/bpfilter/bpfilter_umh_blob.o' being placed in section `.bpfilter_umh'
>
> Fixes: 61fbf5933d42 ("net: bpfilter: restart bpfilter_umh when error occurred")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-16 23:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-15 16:35 [PATCH net] net: bpfilter: change section name of bpfilter UMH blob Taehee Yoo
2019-01-16 23:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).