From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: check return code when requesting PHY driver module
Date: Tue, 15 Jan 2019 23:40:12 +0100 [thread overview]
Message-ID: <20190115224012.GF26788@lunn.ch> (raw)
In-Reply-To: <a47c5dce-5b9a-6a58-a184-c0a250071b93@gmail.com>
> I explicitly check for ret < 0. If there's no PHY driver module for
> a specific PHY ID then the return code would be > 0.
> My understanding of request_module() is that a return code < 0
> is returned if something bad happens in modprobe() call as such.
Ah, O.K. I was expecting an ENODEV or similar if there was no module
to load.
I wonder if this depends on the user space implementation? busybox
might do something different to udev?
Maybe add a comment about the expectation that no error is given when
the module does not exist.
Andrew
next prev parent reply other threads:[~2019-01-15 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 20:33 [PATCH net-next] net: phy: check return code when requesting PHY driver module Heiner Kallweit
2019-01-15 21:43 ` Andrew Lunn
2019-01-15 21:52 ` Heiner Kallweit
2019-01-15 21:58 ` Heiner Kallweit
2019-01-15 22:40 ` Andrew Lunn [this message]
2019-01-15 22:32 ` Florian Fainelli
2019-01-16 6:06 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115224012.GF26788@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).