From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC621C43387 for ; Tue, 15 Jan 2019 23:50:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7C5120656 for ; Tue, 15 Jan 2019 23:50:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="MwJUBzaK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391535AbfAOXuW (ORCPT ); Tue, 15 Jan 2019 18:50:22 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:35084 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729691AbfAOXuW (ORCPT ); Tue, 15 Jan 2019 18:50:22 -0500 Received: by mail-wm1-f68.google.com with SMTP id t200so203427wmt.0 for ; Tue, 15 Jan 2019 15:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AUdM6K2k283ce5Gqt3YEo6BDIzh56v5nFh61YcGlB3g=; b=MwJUBzaKNNwvZPv2+HrJztr2H4Ora4f6r7mRkgXEDLxGoreg4VQLDgjtkpaMjcEqW5 A7NpHNmL1aiv3bJQwSoI/e9U4kyvloWB9GDpFCi2Wdk+2/ImfUdHhAKTpd8hSKnECj74 sXN9pk1EDgX7suaKg/roRflzdtHL+Uy1dP6RujIvexn/RsD/EF74CvgVlxcU6fcttTOz vo/VUMO3jGhA5ZqlxaaVUh4jVEIg5rIXO0gQsQC8n5Ke5xess41iAB44Z3FU+S/ADHZh vBX9YoXTmvSgRljdsJq3wvqs+Aj+1kUSkl2+mPIlGK2tB5RYUXJBFsipAIHPBZmUyjwu FytA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AUdM6K2k283ce5Gqt3YEo6BDIzh56v5nFh61YcGlB3g=; b=WyPCO78kXwwvdVEzoYzn7ou3v4ua5T0dg9DXzue4F9HV16/W1sLGvSWXOZTsIGuL7w hh5qU+/nsyge24C9C/nfvpKX+JggpxUh3yGa5SBVR9RiGsBQrxVaqHqDvuW2fSbE1kyy nGwNSl9WBL3mKEb54CwC/nUXNrSO6SE4ac9cmw6QcHiPpodRpdZfXOiWlAqO0qLbaPiZ bm/4GBwyaT617zQ8OImFj0XEPDSWImNjbROSUnJo7dec+nMeEx5H9OitDM/IedabQ0uf tzHn/qLWVaKblxiPnwPYjfTfrH5k5BFUW6W4d+kk21zlZDLXbSiSMYw1lyo5hSEroxVN 0rIg== X-Gm-Message-State: AJcUukeWjr3Uq5vMh7qfBZ5Y1tJIY7+fIwC/ZvUmx3m2+fEUCpd4iJv4 zIvFFiQ5FV1cNCZJYYzv7j5neA== X-Google-Smtp-Source: ALg8bN6MlXowAreb3XazM7NFiRiJhzN9RwnEEdMqALs7b81+EGIOO2H6owyaBsYYSc7Dyt2jJvZR3Q== X-Received: by 2002:a1c:9ed7:: with SMTP id h206mr4922000wme.28.1547596220030; Tue, 15 Jan 2019 15:50:20 -0800 (PST) Received: from localhost (ip-89-177-6-176.net.upcbroadband.cz. [89.177.6.176]) by smtp.gmail.com with ESMTPSA id k19sm111988221wre.5.2019.01.15.15.50.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 15:50:19 -0800 (PST) Date: Wed, 16 Jan 2019 00:41:48 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: Jonathan Lemon , davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [RFC net-next 0/6] devlink: add device (driver) information API Message-ID: <20190115234148.GB5265@nanopsycho> References: <20190115005009.16025-1-jakub.kicinski@netronome.com> <7B7B83D2-5F56-4E7D-A313-4F8E48B23119@gmail.com> <20190115130642.0113288e@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190115130642.0113288e@cakuba.netronome.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Jan 15, 2019 at 10:06:42PM CET, jakub.kicinski@netronome.com wrote: >On Tue, 15 Jan 2019 11:30:10 -0800, Jonathan Lemon wrote: >> On 14 Jan 2019, at 16:50, Jakub Kicinski wrote: >> >> > Hi! >> > >> > For quite some time now the ethtool -i API has been showing its age. >> > The driver version field is generally considered obsolete these >> > days, and driver authors are encouraged to report the kernel version. >> > fw_version field does not suit modern needs with 31 characters being >> > quite limiting on more complex systems. There is also no distinction >> > between the running and flashed versions of the firmware. >> > >> > Since the driver information pertains to the entire device, rather >> > than a particular netdev, it seems wise to move it do devlink, at >> > the same time fixing the aforementioned issues. >> > >> > The new API allows exposing the device serial number and versions >> > of the components of the card - both hardware, firmware (running >> > and flashed). Driver authors can choose descriptive identifiers >> > for the version fields. There is a potential for defining common >> > fields here, but given the general direction of the stack I don't >> > think people would like that. >> > >> > Example: >> > $ devlink info show >> > pci/0000:05:00.0: >> > serial_number: 00:15:4d:12:20:7e >> > versions: >> > fixed: >> > board.model carbon >> > board.partno AMDA0099-0001 >> > board.revision 07 >> > board.vendor SMA >> > running: >> > fw.mgmt: 010156.010156.010156 >> > fw.cpld: 0x44 >> > fw.app: sriov-2.1.16 >> > stored: >> > fw.mgmt: 010158.010158.010158 >> > fw.cpld: 0x44 >> > fw.app: sriov-2.1.20 >> >> How about adding the driver name and version as well? >> When connecting to an unknown system, "ethtool -i" is useful in >> discovering what is actually running. > >I'm happy to add the driver name, I'd, however, rather steer clear of Agreed. I intended to do that for initial devlink implementation. >the driver version. In most scenarios kernel version is most reliable. >It's mostly out-of-tree drivers that need the driver version. Yep. The "driver version" really makes no sense.