From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 662F3C43387 for ; Wed, 16 Jan 2019 06:28:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 333D120840 for ; Wed, 16 Jan 2019 06:28:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UYCwae0B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387611AbfAPG2S (ORCPT ); Wed, 16 Jan 2019 01:28:18 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:43311 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730888AbfAPG2R (ORCPT ); Wed, 16 Jan 2019 01:28:17 -0500 Received: by mail-pl1-f196.google.com with SMTP id gn14so2488811plb.10 for ; Tue, 15 Jan 2019 22:28:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ff/eQLEurDBWqTZNgXFxGhNKCP63rp36t21KjL9S7ik=; b=UYCwae0BgYi3ZIBScpaV5TD3pePF1J+UOFuUkL+JirBXFLwMwN/CD9L3r7XNk4FwWf YUj14R6gJOq7BZIi43KIUcojmRWI4iRXZ/D4lAMZBUEpzR+YBjOVxtkrg/FrZqBVBOKT U7seyWM3K/ZTbQ3nh4efVKyEYuiRRMxmwKKud7CEJNUsaGdZnz2XsUs72qTpMebQAKUd /xPiJkxArSJUczkvT/aiM2dRtks7tBzjJcSMkkoAbLmIxx6Sz1I7jbAZL5+RmQIaWk3o v3vh28UUZRZrdeY5X6L4M/M5A8CdbBFnddBnIzwiqoabQLlkz2y9m4fMHCJFfCikxaga EgpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ff/eQLEurDBWqTZNgXFxGhNKCP63rp36t21KjL9S7ik=; b=lNfeYqGBa7w4vZCxOHsUmLq7YUfaO0F9Azu4boMMH8JEwluSracPgmzEhAnxLW0BGk o7PyWGOKNhlcXhlHJMVJpYHaNQXrJKJqHUZBXNohmloXx9nIcXZN9Wv0O5hUZndp9ac0 E0i8C3JQyNBuKHtyCbEpFLrS2kDvZ59hpnS8NjnRsUUp1gJQLzLtneTd5lylq/IWgw8S CgBNYn+IhNmMmZXMSblTmme3Z7g9ZBMFVxYQzs2SEl0NVqaFJp6c0DGfKHPOBUijaeX7 3WXlR91U22A3+q7mg5H3tk7mnYdgpezIiNXqLr3xzhJVcGiEITCY/qHJg/FTY5QFwR7X i7tg== X-Gm-Message-State: AJcUukdzOc39j63LwglkaFkWBoC/UfKTQIJioJCdXT+dDr2DuVloXkZU BtmsVml12FKH69LL6adGoCg= X-Google-Smtp-Source: ALg8bN4KFV6dL9J02yRIuAuOhM32TQSHemwzLwCD2MDxcRmsvrcFQJY0YWz/92pwR42c3dNH/gAaXw== X-Received: by 2002:a17:902:5a86:: with SMTP id r6mr7912560pli.301.1547620097122; Tue, 15 Jan 2019 22:28:17 -0800 (PST) Received: from ast-mbp ([2620:10d:c090:180::1:7176]) by smtp.gmail.com with ESMTPSA id j21sm8150459pfn.175.2019.01.15.22.28.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Jan 2019 22:28:15 -0800 (PST) Date: Tue, 15 Jan 2019 22:28:12 -0800 From: Alexei Starovoitov To: Yonghong Song Cc: Alexei Starovoitov , "davem@davemloft.net" , "daniel@iogearbox.net" , "jakub.kicinski@netronome.com" , "netdev@vger.kernel.org" , Kernel Team Subject: Re: [PATCH bpf-next 8/9] libbpf: introduce bpf_map_lookup_elem_flags() Message-ID: <20190116062811.3e3ein2i5b4rkdio@ast-mbp> References: <20190116050830.1881316-1-ast@kernel.org> <20190116050830.1881316-9-ast@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 16, 2019 at 06:18:30AM +0000, Yonghong Song wrote: > > > On 1/15/19 9:08 PM, Alexei Starovoitov wrote: > > Introduce > > int bpf_map_lookup_elem_flags(int fd, const void *key, void *value, __u64 flags) > > helper to lookup array/hash/cgroup_local_storage elements with BPF_F_LOCK flag. > > > > Signed-off-by: Alexei Starovoitov > > --- > > tools/lib/bpf/bpf.c | 13 ++ > > tools/lib/bpf/bpf.h | 2 + > > tools/lib/bpf/libbpf.map | 4 + > > tools/lib/bpf/tags | 254 +++++++++++++++++++++++++++++++++++++++ > > I think this tools/lib/bpf/tags is not needed and accidentally slipped > in due to cscope? Oops. Funny how checkpatch.pl commented about it: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 it didn't mention the file by name, so I ignored that warning. Please continue reviewing. I will respin.