From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F098C43387 for ; Thu, 17 Jan 2019 00:35:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49FC92077B for ; Thu, 17 Jan 2019 00:35:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="uYwFEDLv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731316AbfAQAe7 (ORCPT ); Wed, 16 Jan 2019 19:34:59 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:37656 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731282AbfAQAe5 (ORCPT ); Wed, 16 Jan 2019 19:34:57 -0500 Received: by mail-qt1-f196.google.com with SMTP id t33so9484606qtt.4 for ; Wed, 16 Jan 2019 16:34:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=HaOh+n6UMG7cKy+EctKym9w1okUjuJolKc+vsgPX500=; b=uYwFEDLvMFOR70nOuut1VZifIwDcxpG/kpqaDYJek7Y/+lb8qL3KYbN4CkRpsWpbcC x2gwQSXAStZEGE6/yNrTmkvQGDS9xX8OXuLR1WIl9qbDY4nmSgfH10BiRqyl6v5kwSsW X2FTwRLjsDa2qIJiaSSjwyAaPsP85MO5Sgu1SHIJmk6iPxBFwgZfsggYCLu661Zs/56N JKJznVDN9PxAR5g1rKBjs4iHp6kA7CQpb2n05VP+yasJTGzxVki9WtYysMAWfSOhodZl DZkg2lzVsiw4eaLqzCVN4ZpSkrJdqnTKx5F4/WTp4WRBsRvH7G4nyZRW/6h0CIWCuOeN IJNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=HaOh+n6UMG7cKy+EctKym9w1okUjuJolKc+vsgPX500=; b=GTOoTwbRVS6Y5ta69TRiStdLA5jzpyvDsDSJd9lVgx+dJqjNSFm+dcRRECMpE42h4p 3M/qnoK4S3Vj3LTtX6Evl/5+UVUqu1vx+zqQAoxHgqyuToWorV8PP0eSU0wHU6OPPq1G jTtGItpxdrkGt+wCa16JSTLp9QNLhE86Ltv/+2MrUnTk6c00tXUqk13dOGlSOSgse8XR xDZ++xkRxs00gU6bagrBonQDeauigL9bsbxsg+TUL212Z4Vwdk29dt+Ni/BCB8+8oDai MyZL7IOzwx3fz0BgjMDWjD6kGQMbQV7ZnbAHFM9IAsi8Hiwmx99t29eWm+T/B8cUOkgi w7sQ== X-Gm-Message-State: AJcUukf3ivOZoiIRMFFLXgjV4/kjYS2uPu/N1v4QL0CzpO2j1zjbcMpy OTto/5mG21ZeN+zYKZd/0Rjj2w== X-Google-Smtp-Source: ALg8bN476+0vjNIXz1J7BuYWyyiRYuN6+83fV4u9zjoq8s2kpQ62IUtrl8vROnYkCw5fxPHjWGKoUw== X-Received: by 2002:a0c:db04:: with SMTP id d4mr9287158qvk.114.1547685296819; Wed, 16 Jan 2019 16:34:56 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id o128sm42273889qkc.7.2019.01.16.16.34.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 16:34:56 -0800 (PST) Date: Wed, 16 Jan 2019 16:34:51 -0800 From: Jakub Kicinski To: Quentin Monnet Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, oss-drivers@netronome.com, Arnaldo Carvalho de Melo , Jesper Dangaard Brouer , Stanislav Fomichev Subject: Re: [PATCH bpf-next v4 3/9] tools: bpftool: add probes for kernel configuration options Message-ID: <20190116163451.0da02e3b@cakuba.netronome.com> In-Reply-To: <20190116142119.8358-4-quentin.monnet@netronome.com> References: <20190116142119.8358-1-quentin.monnet@netronome.com> <20190116142119.8358-4-quentin.monnet@netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 16 Jan 2019 14:21:13 +0000, Quentin Monnet wrote: > +static void probe_kernel_image_config(void) > +{ > + const char * const options[] = { nit: static > + /* Enable BPF */ > + "CONFIG_BPF", > + /* Enable bpf() syscall */ > + "CONFIG_BPF_SYSCALL", > + /* Does selected architecture support eBPF JIT compiler */ > + "CONFIG_HAVE_EBPF_JIT", > + /* Compile eBPF JIT compiler */ > + "CONFIG_BPF_JIT", > + /* Avoid compiling eBPF interpreter (use JIT only) */ > + "CONFIG_BPF_JIT_ALWAYS_ON",