From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFB5C43387 for ; Wed, 16 Jan 2019 16:40:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 864D520657 for ; Wed, 16 Jan 2019 16:40:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388047AbfAPQkJ (ORCPT ); Wed, 16 Jan 2019 11:40:09 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:34456 "EHLO mail-wr1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726593AbfAPQkJ (ORCPT ); Wed, 16 Jan 2019 11:40:09 -0500 Received: by mail-wr1-f46.google.com with SMTP id j2so7734817wrw.1 for ; Wed, 16 Jan 2019 08:40:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MIClazzpLReR1AubgLM6ctKtM04SUJoDhXcguiNkhKk=; b=GPDAkx8M0o3biIztr2CZmCtNgAH6V6CWIpPrx2bYhiRgQ9q5J3jq3edCdy51IJW5Me 9LFAph3vzhI7l+eklBgqnLbJfF4cRPHqZS4TwYpo1/1VYb76xioee2oQLM7Pg9w0PzIW /R/zGQgDOU+iMKCIrj7Y8vtcS1sc/cQxAwvFRQ/2BJhEtZ/UqJZJHC1CPsSGukacppA8 8kW7/vBx3I3Dm4V28MvOAFXx4LT/Ivf4492eOzXAIROWzpIbAw3LtM4lcs1BLefCZbde 92U4mavxoJ+o/NFzO5+x9psIO0/5jgaK2t1G7bGSObQ+MKGcEFviNWEFMmseYjdTEmQt tW4A== X-Gm-Message-State: AJcUukfq/wMYBBNzzvFL2nZXT04YSYSLfVgjazsDBHuBwyIcIx6nlyht F85D03kkZRvA9KmUZmPOhHOKSw== X-Google-Smtp-Source: ALg8bN5IOjWhgBleodBRml9l1yjsWZRXSfVUGAz/EMIyLwkhsQpojB/Tl7ZFyAXG4PY5NZYyRVaDEA== X-Received: by 2002:a5d:61c4:: with SMTP id q4mr7989853wrv.308.1547656807224; Wed, 16 Jan 2019 08:40:07 -0800 (PST) Received: from localhost.localdomain (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id n6sm34626446wmk.9.2019.01.16.08.40.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 08:40:06 -0800 (PST) Date: Wed, 16 Jan 2019 17:40:04 +0100 From: Lorenzo Bianconi To: Davide Caratti Cc: davem@davemloft.net, netdev@vger.kernel.org, u9012063@gmail.com Subject: Re: [PATCH net] net: ip6_gre: use erspan key field for tunnel lookup Message-ID: <20190116164003.GC2454@localhost.localdomain> References: <044b51ecc8d0bc21faf8755e2f3014e8b65d71ec.1547569872.git.lorenzo.bianconi@redhat.com> <568fc3d4505d6a1725a4e1e59f43f0af0ac10f8c.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <568fc3d4505d6a1725a4e1e59f43f0af0ac10f8c.camel@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > hi Lorenzo, > > are we sure that 'ershdr' is in the linear part of skb? if not, we might > need a call to pskb_may_pull() here. Hi Davide, thx for the review. I agree, I think we should check erspan header with pskb_may_pull in gre_parse_header. In this way we can remove the check in ip6erspan_rcv() and erspan_rcv(). I will fix in v2 Does '((*(u8 *)options & 0xF0) != 0x40)' have the same issue? Regards, Lorenzo > > thanks! > -- > davide > > >