From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86253C43387 for ; Thu, 17 Jan 2019 00:42:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BFDD20657 for ; Thu, 17 Jan 2019 00:42:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="1PVhBPMO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726880AbfAQAmY (ORCPT ); Wed, 16 Jan 2019 19:42:24 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:45747 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbfAQAmY (ORCPT ); Wed, 16 Jan 2019 19:42:24 -0500 Received: by mail-qk1-f193.google.com with SMTP id y78so4985166qka.12 for ; Wed, 16 Jan 2019 16:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=sfdWOZJRHpFMmYAr0Z+rm/orOVGvAgI2eIrbWDwfwMQ=; b=1PVhBPMOe32DX7CE82MiAAy1CqFWPYm3yJoY8fzRQTC3ekSWBgDivsUGsKRTq9bfEK fTgCdqXilRrqve3CMGYZc7bc0GTQ4T3hfKEfsy7B4RmZ7ZlktCz9gcKLF+HUpcFQmN5k uUjv4NSkQ2F5MLx0cT3C0Gke6iLiLUAS0DHIf5tUzRDF/a0aW999PWXr+5uG0/EC5sK8 NBN1OYQBnV2VZp/T6xys/MkguHsLHVsUlQ8kHEobRlOjml4616VxrFjPHXZQToxid3F9 gAFjzSkqJRr6GZW2FHoDbNrrx0ddRmfP+s7DLks6N6wPn61N+xzjb1quAFXoEp8xvedD NzqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=sfdWOZJRHpFMmYAr0Z+rm/orOVGvAgI2eIrbWDwfwMQ=; b=qKLfWM0zjkgmeVE1jnPF0qJMBQ9FvHMmzB5HXth2W/Sb13YtUZ+fPKRO3KgeAP4H3V YdlE3hRzh3Dm+VgFmkHAZ6Px2DIFyxKYLc4yEcHAC9M+tqPNcVPcdF7cQlJKKiRJtNEq Pu7WkmdpW17jW6hc9Oz8i/Dsl2FcCjgRw75j09has2a0iL369T4rmS4q71DCsndvYT6J WNDmCGyahj/cMSJly9jJNBWX5x2XR4jsYkNuA5Pyzvz4xzesXBVIu4+WH3PCvAHZT9A6 jpurx9KU7xNuIni12DpN0mSMO7k+NLrIZN+UqX4JtgiOI1/7HNitK+yDrYdB3fisMZRo WAVg== X-Gm-Message-State: AJcUukeVpb6IruqmF9moMFU4zcuq4eaKK5ZzM9qaDtYXhLRZLsTClcFt efr7dJqSUbFG3cd2bnUY4gVciw== X-Google-Smtp-Source: ALg8bN7bND9piMRHZfyj/lXEJc8JsG5L5Ak84T3Ax/8ukiGdrKqOcdOrbjFGZ7W6XMjQkM+hjTlpnQ== X-Received: by 2002:a37:9a89:: with SMTP id c131mr8973423qke.173.1547685743186; Wed, 16 Jan 2019 16:42:23 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id o34sm44279192qte.4.2019.01.16.16.42.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 16:42:23 -0800 (PST) Date: Wed, 16 Jan 2019 16:42:18 -0800 From: Jakub Kicinski To: Quentin Monnet Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, oss-drivers@netronome.com, Arnaldo Carvalho de Melo , Jesper Dangaard Brouer , Stanislav Fomichev Subject: Re: [PATCH bpf-next v4 4/9] tools: bpftool: add probes for eBPF program types Message-ID: <20190116164218.5dab8478@cakuba.netronome.com> In-Reply-To: <20190116142119.8358-5-quentin.monnet@netronome.com> References: <20190116142119.8358-1-quentin.monnet@netronome.com> <20190116142119.8358-5-quentin.monnet@netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 16 Jan 2019 14:21:14 +0000, Quentin Monnet wrote: > diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map > index cd02cd4e2cc3..6355e4c80a86 100644 > --- a/tools/lib/bpf/libbpf.map > +++ b/tools/lib/bpf/libbpf.map > @@ -56,6 +56,7 @@ LIBBPF_0.0.1 { > bpf_object__unpin_maps; > bpf_object__unpin_programs; > bpf_perf_event_read_simple; > + bpf_probe_prog_type; I think you have to start a new 0.0.2 section now, no? > bpf_prog_attach; > bpf_prog_detach; > bpf_prog_detach2; > +bool bpf_probe_prog_type(enum bpf_prog_type prog_type, __u32 ifindex) > +{ > + struct bpf_insn insns[2] = { > + BPF_MOV64_IMM(BPF_REG_0, 0), > + BPF_EXIT_INSN() > + }; > + > + if (ifindex && prog_type == BPF_PROG_TYPE_SCHED_CLS) > + /* nfp returns -EINVAL on exit(0) with TC offload */ > + insns[0].imm = 2; > + > + errno = 0; > + prog_load(prog_type, insns, ARRAY_SIZE(insns), NULL, 0, ifindex); > + > + return errno != EINVAL && errno != EOPNOTSUPP; nit: could you check that errno in the function doing the load? :| also perhaps name that function probe_load()? > +}