From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93EA7C43387 for ; Thu, 17 Jan 2019 00:55:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D64020657 for ; Thu, 17 Jan 2019 00:55:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="RN6OBIaQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727072AbfAQAzV (ORCPT ); Wed, 16 Jan 2019 19:55:21 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:34010 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725648AbfAQAzU (ORCPT ); Wed, 16 Jan 2019 19:55:20 -0500 Received: by mail-qt1-f193.google.com with SMTP id r14so9582868qtp.1 for ; Wed, 16 Jan 2019 16:55:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=lENkbIeRlwUgNJl/RuBXfJBz8rTwIfijAFIM32YBw+4=; b=RN6OBIaQoV4fz2mbsU5AxZEUpgyVTywqwflBzA5swCEBPTNUcDvttWJIfXfrOd/EPV cIu4/1/7gOn+trVk3lu2oLo7Et9oJMnt4GWY2jFKB7pGOzIZAly0vInV2atIfpZkmIjX N2Oal5WN3Ad4uDa93nPcp4TSmQmGaP+JwIk8emphQt8FYDL4hm+hbXMWkdVyDHqQZju3 /xTpBUVK+TODPjXiKMERvFinpd04ysUPxmLJ+2Ue1I6mY8M7etauWRqsmoy0f5CCdPQn b8qMiP9z5gEZc1EyRQ1Q/0snkdJbevcllMqQt2AfWIMfUQEMCKkAMkGJ/6f5roIxuWJn D2LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=lENkbIeRlwUgNJl/RuBXfJBz8rTwIfijAFIM32YBw+4=; b=hP7I+AELV1viXvbmmFpkC7IvrhKVW7KbMijUPku2wT6nYpeKMz0lZWqZMqymShB9+E oTbnb0095qCjmPXfXxux6/r2JBWAYHtFoyYdM2iTrG01fRnjHw+TCy55Ms/oCtLG2AOu 6369O1sJlW9nFKxkKBe80bQB0iApVFcXVelG0enNIMrX6ZzWQNRZ8c+ysSArmz/cZTp6 i+57bgdOI0w2L6DIqkH3GtS8+Fe/t69VIc1CAQq/rBJK6yxBfiGGbnPNQUThIRraHKyW vfRNEnJFBHauqbNP6FMufn5IRwuTZNZP8eYyNgh97DdkqHmx6rNARU3abQbceNG9sylm yp4Q== X-Gm-Message-State: AJcUukeJa4zf1EDpnTxtw23jLcpZgDsbS5JSuBSQmnje1ROpXjyqoDqC Jiq5er6gA/WmQ6MfZ6BKh8gOA3plJbU= X-Google-Smtp-Source: ALg8bN7XkZCtSusfJ7d9cYXbsUHj5lIhs9kilx4Trgb4QZqQvA2ToFeGPwRziBPoLBEDgyprDYkvmA== X-Received: by 2002:a0c:f584:: with SMTP id k4mr9411062qvm.22.1547686518771; Wed, 16 Jan 2019 16:55:18 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id w52sm59484074qtc.51.2019.01.16.16.55.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 16:55:18 -0800 (PST) Date: Wed, 16 Jan 2019 16:55:13 -0800 From: Jakub Kicinski To: Quentin Monnet Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, oss-drivers@netronome.com, Arnaldo Carvalho de Melo , Jesper Dangaard Brouer , Stanislav Fomichev Subject: Re: [PATCH bpf-next v4 0/9] tools: bpftool: add probes for system and device Message-ID: <20190116165513.566973f1@cakuba.netronome.com> In-Reply-To: <20190116142119.8358-1-quentin.monnet@netronome.com> References: <20190116142119.8358-1-quentin.monnet@netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 16 Jan 2019 14:21:10 +0000, Quentin Monnet wrote: > tools/bpf/bpftool/feature.c | 764 ++++++++++++++++++ should we perhaps git mv feature.c probe.c ? (if you create a commit with just a move right after the first commit which adds the file git will figure out its a rename, and the squash this rename into first commit). Minor nits but otherwise feel free to re-add: Reviewed-by: Jakub Kicinski :)