From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4A4C43387 for ; Wed, 16 Jan 2019 19:40:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1232520840 for ; Wed, 16 Jan 2019 19:40:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="h9eolV1s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731554AbfAPTkS (ORCPT ); Wed, 16 Jan 2019 14:40:18 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:45690 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731174AbfAPTkR (ORCPT ); Wed, 16 Jan 2019 14:40:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=W/CfAI0bybUDrdXh3BnTNcXQgS+hgD4zi5YRuJ8c8uA=; b=h9eolV1sXHFYSYjlip2FLSH6a/aT5wGRRGPuJHz5UjjLyyHS6VTOFuByMqS/OLbt6H9AK78sbmiLHYBO3Ed4rCNzqMCGcnxOIOqGAonuoyQ/FhsiyQTv2iE35ClFIVtyZO/MeEJQe1sCCYp+tINimet5RM0CwdFr+kELfc1Zb0E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1gjr2s-0001ML-CQ; Wed, 16 Jan 2019 20:40:14 +0100 Date: Wed, 16 Jan 2019 20:40:14 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next] net: phy: improve stopping PHY Message-ID: <20190116194014.GE24870@lunn.ch> References: <024c1ea8-6547-b27d-948c-63e32b3229f1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <024c1ea8-6547-b27d-948c-63e32b3229f1@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 16, 2019 at 08:20:43PM +0100, Heiner Kallweit wrote: > phy_stop_interrupts() is called from phy_disconnect() only. Most of > what it does has been done by phy_stop() already which should have > been called before phy_disconnect(). Based on that we can do some > improvements: > - remove phy_stop_interrupts() and free interrupt in > phy_disconnect() directly > - replace condition "phydev->irq > 0" with the appropriate helper > - make sure phy state machine is stopped after calling phy_stop() > - check in phy_disconnect() that PHY is in a stopped state. Else > warn to detect misbehaving drivers and call phy_stop(). Hi Heiner When i see a list like this, it makes me think there should be a patchset, not a single patch. If something does break, we can bisect it to just one change. Please could you try to break this up into a few patches. Thanks Andrew