* [PATCH] davicom: Annotate implicit fall through in dm9000_set_io
@ 2019-01-16 19:49 Mathieu Malaterre
2019-01-17 23:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Malaterre @ 2019-01-16 19:49 UTC (permalink / raw)
To: David S. Miller; +Cc: Mathieu Malaterre, netdev, linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warning (W=1).
This commit removes the following warning:
include/linux/device.h:1480:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/net/ethernet/davicom/dm9000.c:397:3: note: in expansion of macro 'dev_dbg'
drivers/net/ethernet/davicom/dm9000.c:398:2: note: here
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
drivers/net/ethernet/davicom/dm9000.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c
index 0a82fcf16d35..c2586f44c29d 100644
--- a/drivers/net/ethernet/davicom/dm9000.c
+++ b/drivers/net/ethernet/davicom/dm9000.c
@@ -395,6 +395,7 @@ static void dm9000_set_io(struct board_info *db, int byte_width)
case 3:
dev_dbg(db->dev, ": 3 byte IO, falling back to 16bit\n");
+ /* fall through */
case 2:
db->dumpblk = dm9000_dumpblk_16bit;
db->outblk = dm9000_outblk_16bit;
--
2.19.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] davicom: Annotate implicit fall through in dm9000_set_io
2019-01-16 19:49 [PATCH] davicom: Annotate implicit fall through in dm9000_set_io Mathieu Malaterre
@ 2019-01-17 23:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-17 23:08 UTC (permalink / raw)
To: malat; +Cc: netdev, linux-kernel
From: Mathieu Malaterre <malat@debian.org>
Date: Wed, 16 Jan 2019 20:49:25 +0100
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit removes the following warning:
>
> include/linux/device.h:1480:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/net/ethernet/davicom/dm9000.c:397:3: note: in expansion of macro 'dev_dbg'
> drivers/net/ethernet/davicom/dm9000.c:398:2: note: here
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-17 23:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-16 19:49 [PATCH] davicom: Annotate implicit fall through in dm9000_set_io Mathieu Malaterre
2019-01-17 23:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).