From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3421FC43444 for ; Wed, 16 Jan 2019 22:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F33A820651 for ; Wed, 16 Jan 2019 22:03:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IXhGN+71" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732344AbfAPWDY (ORCPT ); Wed, 16 Jan 2019 17:03:24 -0500 Received: from mail-qt1-f201.google.com ([209.85.160.201]:46611 "EHLO mail-qt1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731870AbfAPWDY (ORCPT ); Wed, 16 Jan 2019 17:03:24 -0500 Received: by mail-qt1-f201.google.com with SMTP id w19so7142226qto.13 for ; Wed, 16 Jan 2019 14:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=CiI0H6GGu9ZZYNDI4Vuo9O1Dk40PGKSmJmouWQEzEyk=; b=IXhGN+71gpGcGlAKzA/8KRd9++ks2I15N6smFq8Iw1wu8EmmZ/2bmitEc2cm9G8pr4 lxbcRdo9aLbiXOCvW5IYqQdASTfP124mHM0WM49VZ4/A6+iNWaq5OuhTDsJsUw+CRUen Gyazm3SJvmlfy+ICFAkBbTCo0YCrK2mMjnZ/k6ZrRLYZ9Ns+7bZ+kpFuvh2R1ov76UxS qj5KDdi+7Jm8f0DBuMqCwJzA2LW1p6NeX0tiHXHayFrQxmJ+T6Q3XixyhkjsjtwxmdrD 2M9p9mfqD/nd56hGbTIIIkWRRT7nN6J3ydNa+qW1XUHbBP68PKonJAtt2XBIpKBSb9Q4 WyEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=CiI0H6GGu9ZZYNDI4Vuo9O1Dk40PGKSmJmouWQEzEyk=; b=Pg1Ck09WxvE0uFDjJHKQ56b+URTTmVM33GQSyrwhR94MT9N9gIBa9k8fzfhR+eA1Ur eJ/hfIhLrclR4jcn+XC9XXME/zxbl5p7mN7CD3Brv7f9YS0n0s/u/1apKL7FI7aJ2Bm3 ng5nv1z/bgk/FZhacprZf8aYhJoYC+lEd1UIP2Ln0H5hr8z+cSSiaCHzHF3r692SH92Q AgEYIv5n4c1AtjyudUK1ptVEumcXquHfwRbVNiVc5lyg+Sz/EuodNAbxdZSpBaRT4orI FU661KwhEpuyE09MP09Y5LNPeJggZozYL6KFbNKDpR1kZzXdJqFB3XVx5Ho2fJw7xFjb gYZw== X-Gm-Message-State: AJcUukdguK2eqRjsmF5ViIoX0tdm7C/ja5AHt1Qai00NfDPVUi4j8+w5 41ApZ4O5Rc4Mwpgdp667QygAnh9gCO3Dq4p5w/lvIuGcIE1O7sWPIsiSaTZmdk6IxOL+1sOyE23 xpo/H/E7hkUzWSkS/gUrdm0b46g6TK9/Ui62qko3CBtVfRv4E3SpTKA== X-Google-Smtp-Source: ALg8bN4BHD2bzZ+0eQMWj2kLitIhZOXp41xsEabSgoV88QQ3H/1jCqLfrCy9K6UxQhkbr5QQqSbY1PY= X-Received: by 2002:a37:4916:: with SMTP id w22mr5932081qka.6.1547676203442; Wed, 16 Jan 2019 14:03:23 -0800 (PST) Date: Wed, 16 Jan 2019 14:03:16 -0800 In-Reply-To: <20190116220317.30907-1-sdf@google.com> Message-Id: <20190116220317.30907-2-sdf@google.com> Mime-Version: 1.0 References: <20190116220317.30907-1-sdf@google.com> X-Mailer: git-send-email 2.20.1.97.g81188d93c3-goog Subject: [PATCH bpf v2 2/3] bpf: zero out build_id for BPF_STACK_BUILD_ID_IP From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, songliubraving@fb.com, Stanislav Fomichev Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When returning BPF_STACK_BUILD_ID_IP from stack_map_get_build_id_offset, make sure that build_id field is empty. Since we are using percpu free list, there is a possibility that we might reuse some previous bpf_stack_build_id with non-zero build_id. Fixes: 615755a77b24 ("bpf: extend stackmap to save binary_build_id+offset instead of address") Acked-by: Song Liu Signed-off-by: Stanislav Fomichev --- kernel/bpf/stackmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c index f9df545e92f6..d43b14535827 100644 --- a/kernel/bpf/stackmap.c +++ b/kernel/bpf/stackmap.c @@ -314,6 +314,7 @@ static void stack_map_get_build_id_offset(struct bpf_stack_build_id *id_offs, for (i = 0; i < trace_nr; i++) { id_offs[i].status = BPF_STACK_BUILD_ID_IP; id_offs[i].ip = ips[i]; + memset(id_offs[i].build_id, 0, BPF_BUILD_ID_SIZE); } return; } @@ -324,6 +325,7 @@ static void stack_map_get_build_id_offset(struct bpf_stack_build_id *id_offs, /* per entry fall back to ips */ id_offs[i].status = BPF_STACK_BUILD_ID_IP; id_offs[i].ip = ips[i]; + memset(id_offs[i].build_id, 0, BPF_BUILD_ID_SIZE); continue; } id_offs[i].offset = (vma->vm_pgoff << PAGE_SHIFT) + ips[i] -- 2.20.1.97.g81188d93c3-goog