From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61434C43387 for ; Thu, 17 Jan 2019 08:38:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FC2C20859 for ; Thu, 17 Jan 2019 08:38:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="UlhaIWdG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728259AbfAQIix (ORCPT ); Thu, 17 Jan 2019 03:38:53 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:43724 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727284AbfAQIiw (ORCPT ); Thu, 17 Jan 2019 03:38:52 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0H8YSlB043742; Thu, 17 Jan 2019 08:38:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=HQRKfJnh4YuDPtT7A1JSxKNOD8ppHABefQcFbO121Rk=; b=UlhaIWdGbgZvZDsy2znu02TudHa2awDEEiLK9bdT6k++45m6a1hjL9YVbNdDtiw7i/pg I+MYjIr58aAXpJ5FDV/PMvssJGVYRfji9bS9/7VmQs08mVlwe4xGrOBmSJ8DMMcoL5Je 3ooxQ/t/o/EUwr2wkEc6FGDUeFRX+BeqDCs2Sg1cQia2voFP4cg1/cFtpnpL1/tZv0td iuqNL6mEMNtFB+vEHm0Uty0IAb13Vm/Wr9iD2CFBpWRQohH3Hc0uiz+xJzJ4JThinW2y nmcz2RiyrvojZrjJa/wL4rkdZ0QTXTxVY3lgNzb/UgBo+qjS084vr6JqGuR2FBdSlobN 1A== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2pybjnxfn9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jan 2019 08:38:26 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x0H8cPrT009919 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jan 2019 08:38:25 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x0H8cJr4006895; Thu, 17 Jan 2019 08:38:20 GMT Received: from kadam (/197.157.0.55) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 17 Jan 2019 00:38:19 -0800 Date: Thu, 17 Jan 2019 11:38:04 +0300 From: Dan Carpenter To: Tristram.Ha@microchip.com Cc: Sergio Paracuellos , Marek Vasut , Andrew Lunn , Florian Fainelli , Pavel Machek , vivien.didelot@savoirfairelinux.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org Subject: Re: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver Message-ID: <20190117080949.GN4504@kadam> References: <1547695462-31618-1-git-send-email-Tristram.Ha@microchip.com> <1547695462-31618-2-git-send-email-Tristram.Ha@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547695462-31618-2-git-send-email-Tristram.Ha@microchip.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9138 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=667 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901170063 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org No need to send this as an RFC patch. Adding a new driver is normal and uncontroversial. On Wed, Jan 16, 2019 at 07:24:22PM -0800, Tristram.Ha@microchip.com wrote: > + > + i2c_set_clientdata(i2c, dev); ^^^ > + > + return 0; > +} > + > +static int ksz9477_i2c_remove(struct i2c_client *i2c) > +{ > + struct ksz_device *dev = i2c_get_clientdata(i2c); > + > + if (dev) ^^^ No need. > + ksz_switch_remove(dev); > + > + return 0; > +} > + regards, dan carpenter