From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7754C43444 for ; Thu, 17 Jan 2019 16:36:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DC0F20851 for ; Thu, 17 Jan 2019 16:36:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cnf4GBIR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728885AbfAQQgv (ORCPT ); Thu, 17 Jan 2019 11:36:51 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:42266 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726854AbfAQQgu (ORCPT ); Thu, 17 Jan 2019 11:36:50 -0500 Received: by mail-qt1-f195.google.com with SMTP id d19so11947623qtq.9 for ; Thu, 17 Jan 2019 08:36:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=vOrcPS1kBhZGENDr6xUAA47aMbnIFOs4/KpmwrMfoeI=; b=cnf4GBIRY6Vw6Z+mc0URXVLd63FPHRP4t4fcIojnGS26p1m3+zXw/KElAmdJePyTa2 Kf5/X3xojtUQBwmMbUdMvqdf5tG/lhBDxZo2tPp2O9yI4rGMTEGgm+0eoipYs6vUZj7b u/IJ6yXZSCH03A2grXbY1BfK64cr15ZSkq3p+zBDOzI2cwzfSNG1WPouQV9BVI/P0H6S pIIbsxi07r/+GPysBSc/MAuQpgVjXao2+aERQ6rl5q450/G2zZ+uH380i7AbXVGQ1FFR RzgXiMUbFkUUFLHi3TsxOMjkYkBAbMVvpnBTPOaiKQ/TqYR/kMV15HGFG7dglhtmAXoX gPFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=vOrcPS1kBhZGENDr6xUAA47aMbnIFOs4/KpmwrMfoeI=; b=Jis37xkhIcFa7P2on/03BtVmliKmU4EXq1BN1JtghTb6L8yLltVSlxxUI3SklkoKOI himfcs3RMbF/sG4mQ+2CTkXkW3DNMZ2IyU7so6Ki7lSg0PjlnxDlCBmjTkZZ+wFVhZCL KbK1dPhKgRdR5KxqmuKlSpfjd4i4IVctbrlsdvFNKnKXDWHYwR0z3PdVdu+9M9XMDV3e hSRFso1trUx4raSwPIyxlcTw0C1gQv8SeYqv8ovX/EgLLfqBPiEnpEuiI7A8eEaTBDWI B4HMDqazolU5r6V0Cctdi1vaiXmMdvpDKfS4S9vHiNc/zSuRrx+RFFv8iiFxeSVg+QHS jsQQ== X-Gm-Message-State: AJcUukfMr9SkXkWcNJgLL8h6tjxpw5D9Zff2yvBwb14ySHhclVSZOl4T zprL85kSzurUdfAPEsYoGHI= X-Google-Smtp-Source: ALg8bN4AcN3vOHtwkjR9z2L09fUXFDHFHik2qydJpw7EAHsH4dX408OykdUNQlqk8Vrzq0isTQ54dw== X-Received: by 2002:a0c:9418:: with SMTP id h24mr12105994qvh.216.1547743009262; Thu, 17 Jan 2019 08:36:49 -0800 (PST) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id x49sm68782991qta.89.2019.01.17.08.36.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 08:36:48 -0800 (PST) Date: Thu, 17 Jan 2019 11:36:47 -0500 Message-ID: <20190117113647.GF13242@t480s.localdomain> From: Vivien Didelot To: Florian Fainelli Cc: netdev@vger.kernel.org, Florian Fainelli , andrew@lunn.ch, davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com Subject: Re: [PATCH net-next 03/14] net: dsa: b53: Properly account for VLAN filtering In-Reply-To: <20190116200102.2749-4-f.fainelli@gmail.com> References: <20190116200102.2749-1-f.fainelli@gmail.com> <20190116200102.2749-4-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Florian, On Wed, 16 Jan 2019 12:00:51 -0800, Florian Fainelli wrote: > + /* Handle the case were multiple bridges span the same switch device > + * and one of them has a different setting than what is being requested > + * which would be breaking filtering semantics for any of the other > + * bridge devices. > + */ > + b53_for_each_port(dev, i) { > + bridge_dev = dsa_to_port(ds, i)->bridge_dev; > + if (bridge_dev && > + bridge_dev != dsa_to_port(ds, port)->bridge_dev && > + br_vlan_enabled(bridge_dev) != vlan_filtering) { > + netdev_err(bridge_dev, > + "VLAN filtering is global to the switch!\n"); > + return -EINVAL; > + } > + } Unbridged ports must act as standard NICs and thus forward taggued frames. What happens to them if there's a bridge with VLAN filtering enabled spawned on other ports of your switch? Will the unbridged ports filter VLAN? Thanks, Vivien