From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5ADC43387 for ; Thu, 17 Jan 2019 11:19:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 313352054F for ; Thu, 17 Jan 2019 11:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728542AbfAQLTa (ORCPT ); Thu, 17 Jan 2019 06:19:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16212 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726826AbfAQLTa (ORCPT ); Thu, 17 Jan 2019 06:19:30 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 88C09C0587FE; Thu, 17 Jan 2019 11:19:30 +0000 (UTC) Received: from localhost (ovpn-200-21.brq.redhat.com [10.40.200.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 431206063D; Thu, 17 Jan 2019 11:19:25 +0000 (UTC) Date: Thu, 17 Jan 2019 12:19:24 +0100 From: Jesper Dangaard Brouer To: Maciej Fijalkowski Cc: daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com Subject: Re: [PATCH bpf-next 2/6] samples: bpf: Convert XDP samples to libbpf usage Message-ID: <20190117121924.033d3106@redhat.com> In-Reply-To: <20190117010115.18234-3-maciejromanfijalkowski@gmail.com> References: <20190117010115.18234-1-maciejromanfijalkowski@gmail.com> <20190117010115.18234-3-maciejromanfijalkowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 17 Jan 2019 11:19:30 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 17 Jan 2019 02:01:11 +0100 Maciej Fijalkowski wrote: > xdp_redirect_cpu is omitted because of read_trace_pipe() usage, which > doesn't seem to be handled in libbpf ATM. The sample xdp_redirect_cpu, doesn't need to use read_trace_pipe(). I'll send a patch to remove it (that you can include in your patchset). It must be a left-over when I was developing this... as it doesn't do any bpf_trace_printk calls. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer