From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F112C43387 for ; Thu, 17 Jan 2019 18:36:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E1C620851 for ; Thu, 17 Jan 2019 18:36:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="okjIOnxw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727277AbfAQSgJ (ORCPT ); Thu, 17 Jan 2019 13:36:09 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:35795 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbfAQSgJ (ORCPT ); Thu, 17 Jan 2019 13:36:09 -0500 Received: by mail-qt1-f193.google.com with SMTP id v11so12484372qtc.2 for ; Thu, 17 Jan 2019 10:36:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=42/jZTZms5CwVgs4vk8TRk3nAR9CQgQlxopsq3azO1w=; b=okjIOnxwZRjJQQfuOlVo9BqajriuBNjRfxiz+ZUB/ZheC86saiWJyw9DAqznPx0B0h WXTPZoEvBx+AdvRfsTrVa4ds1OdmrBtLp/8YERkJ23IfW/XS0OGxvZYUUxejJsNYDf3W CbNDFFW7Mc9HoO24J+cWMddfp1ys0/Q/BFCwcHG+ohI92LA4NKb6dr5wN5VfZYw2SVxa dDkAjn448HHbbGX7iNKwvlZWFQQ2JEkBl5xx2hFFbwEcrgRlv8z7c+5mUyJY3FkpzZrG 1PfLOS/kqmW/7ut3MT2l/GID2V1tuNGic8J8bHFzJPiHmRakt4WIXTm5Gi9PMxJg4lft TiXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=42/jZTZms5CwVgs4vk8TRk3nAR9CQgQlxopsq3azO1w=; b=ujPHiu/9lX7Nc1D9XqXj/puSwz7YafVA6a++kAFl+XcEAqvfhld4zo3cw3ZKc/qW59 ePV/8Vb8MKBjwypBh2t/8onyRO+biJWk4Wfgori4V4K29FbTsfVebrrJ9rszUux4aJoj dTecqnuTeFLTGz7LTYte/exrsmXVCtkNPEK7iKnEDhcctcBtUS4gkJOQwBg2MwfjiZKS yOC6CtYgWfvx4qEBI1ssTifFNYqSTlh0rHFU1N0oJcWzNFPrOunSpo14n+WzZNq0HgkK IMrKFYp5jGSHQpvdGkd37Gd1Vwni162tyB0rQf8HCe1VkYJlth/lF1loz+SLh1pmKr6r k2/w== X-Gm-Message-State: AJcUukcm08L0Q3uPke2N2ucQzcjRyC6I1/hl47xh87xLGLZvQ8t/RbpC KwIb+LpkgbOphsZzeBTDYXY= X-Google-Smtp-Source: ALg8bN5cVWAvaMYKhDcZ1fTIf9EYDEotiTLUSyglqiLCg+0cRXL7u88C5c6WSeHYieWTmC6kfFW9Bg== X-Received: by 2002:aed:35c5:: with SMTP id d5mr12588888qte.212.1547750168041; Thu, 17 Jan 2019 10:36:08 -0800 (PST) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id x57sm60751104qtx.96.2019.01.17.10.36.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 10:36:07 -0800 (PST) Date: Thu, 17 Jan 2019 13:36:06 -0500 Message-ID: <20190117133606.GH13242@t480s.localdomain> From: Vivien Didelot To: Florian Fainelli Cc: netdev@vger.kernel.org, Florian Fainelli , andrew@lunn.ch, davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com Subject: Re: [PATCH net-next 12/14] net: dsa: Wire up multicast IGMP snooping attribute notification In-Reply-To: <20190116200102.2749-13-f.fainelli@gmail.com> References: <20190116200102.2749-1-f.fainelli@gmail.com> <20190116200102.2749-13-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 16 Jan 2019 12:01:00 -0800, Florian Fainelli wrote: > + int (*port_multicast_toggle)(struct dsa_switch *ds, int port, > + bool mc_disabled); Waw this looks counter-intuitive and error-prone... Would you prefer to make it symmetrical to ops->port_vlan_filtering() by implementing ops->port_multicast() and passing !obj->u.mc_disabled to it? Thanks, Vivien